Fix missing imports in daemon tests#1687
Merged
Merged
Conversation
8 tasks
oferchen
added a commit
that referenced
this pull request
May 1, 2026
…nsport (#1938) (#3525) Formalizes the SSH stdio transport audit at docs/audits/ssh-socketpair-vs-pipes.md under tracker #1938, consolidating prior #1686 working notes (PR #3438), the io_uring boundary documented for #1858 (PR #3418), and the stderr socketpair shipped under #1689 (PR #3383). Restructures the document into the formal seven-section layout (summary, upstream reference, current implementation, trade-offs, decision matrix, recommendation, implementation notes) plus findings and references. Recommends keeping anonymous pipes for the SSH wire and not pursuing the socketpair migration: splice(2) and vmsplice(2) require a pipe end, the zero-copy plan in #1860 depends on that, and the unified-FD argument is subsumed by the async-transport refactor (#2068, #1655). Closes #1687 (prototype socketpair wire) as do-not-implement and #1902 (verify wire claim against rsync_io source) as verified. Citations were re-checked against worktree source: builder.rs:300-301 (Stdio::piped on the wire), aux_channel.rs:263-285 (UnixStream::pair for stderr, Unix only), connection.rs:30-39 (SshConnection struct), mod.rs:57-75 (io_uring boundary). Upstream evidence verified against target/interop/upstream-src/rsync-3.4.1/: pipe.c:48-97 (piped_child), util1.c:74-96 (fd_pair), main.c:504-663 (do_cmd dispatch), clientserver.c:116-148 (daemon TCP wire), socket.c:736-846 (sock_exec test escape).
oferchen
added a commit
that referenced
this pull request
May 5, 2026
…nsport (#1938) (#3525) Formalizes the SSH stdio transport audit at docs/audits/ssh-socketpair-vs-pipes.md under tracker #1938, consolidating prior #1686 working notes (PR #3438), the io_uring boundary documented for #1858 (PR #3418), and the stderr socketpair shipped under #1689 (PR #3383). Restructures the document into the formal seven-section layout (summary, upstream reference, current implementation, trade-offs, decision matrix, recommendation, implementation notes) plus findings and references. Recommends keeping anonymous pipes for the SSH wire and not pursuing the socketpair migration: splice(2) and vmsplice(2) require a pipe end, the zero-copy plan in #1860 depends on that, and the unified-FD argument is subsumed by the async-transport refactor (#2068, #1655). Closes #1687 (prototype socketpair wire) as do-not-implement and #1902 (verify wire claim against rsync_io source) as verified. Citations were re-checked against worktree source: builder.rs:300-301 (Stdio::piped on the wire), aux_channel.rs:263-285 (UnixStream::pair for stderr, Unix only), connection.rs:30-39 (SshConnection struct), mod.rs:57-75 (io_uring boundary). Upstream evidence verified against target/interop/upstream-src/rsync-3.4.1/: pipe.c:48-97 (piped_child), util1.c:74-96 (fd_pair), main.c:504-663 (do_cmd dispatch), clientserver.c:116-148 (daemon TCP wire), socket.c:736-846 (sock_exec test escape).
4 tasks
oferchen
added a commit
that referenced
this pull request
May 5, 2026
…3697) Re-checks the thirteen testable claims in docs/audits/ssh-socketpair-vs-pipes.md against current crates/rsync_io/src/ssh/ source. All claims confirmed; two file:LINE citations drifted because of intervening commits (#3637 added the SSH/rsync compression warning, growing builder.rs by ~60 lines). Behaviour is unchanged: anonymous pipes on the wire, socketpair on stderr, no socketpair anywhere on the SSH wire path. Reaffirms the prior recommendation that #1687 (socketpair-prototype) stays closed.
3 tasks
oferchen
added a commit
that referenced
this pull request
May 17, 2026
…#4193) Narrow-scope audit for the single-FD wire variant (one socketpair shared between the child's fd 0 and fd 1) that #1687 proposes. Complements ssh-socketpair-vs-pipes.md (#1938), which ruled out the two-socketpair-per-direction variant. Recommends do-not-implement on the basis of splice eligibility loss, EOF-propagation regression at goodbye, no parent-side simplification, no upstream parity, and the cross-platform asymmetry. Adds a one-line cross-reference in crates/rsync_io/src/ssh/mod.rs so the disposition is discoverable from source.
oferchen
added a commit
that referenced
this pull request
May 18, 2026
…3697) Re-checks the thirteen testable claims in docs/audits/ssh-socketpair-vs-pipes.md against current crates/rsync_io/src/ssh/ source. All claims confirmed; two file:LINE citations drifted because of intervening commits (#3637 added the SSH/rsync compression warning, growing builder.rs by ~60 lines). Behaviour is unchanged: anonymous pipes on the wire, socketpair on stderr, no socketpair anywhere on the SSH wire path. Reaffirms the prior recommendation that #1687 (socketpair-prototype) stays closed.
oferchen
added a commit
that referenced
this pull request
May 18, 2026
…#4193) Narrow-scope audit for the single-FD wire variant (one socketpair shared between the child's fd 0 and fd 1) that #1687 proposes. Complements ssh-socketpair-vs-pipes.md (#1938), which ruled out the two-socketpair-per-direction variant. Recommends do-not-implement on the basis of splice eligibility loss, EOF-propagation regression at goodbye, no parent-side simplification, no upstream parity, and the cross-platform asymmetry. Adds a one-line cross-reference in crates/rsync_io/src/ssh/mod.rs so the disposition is discoverable from source.
oferchen
added a commit
that referenced
this pull request
May 18, 2026
…#4193) Narrow-scope audit for the single-FD wire variant (one socketpair shared between the child's fd 0 and fd 1) that #1687 proposes. Complements ssh-socketpair-vs-pipes.md (#1938), which ruled out the two-socketpair-per-direction variant. Recommends do-not-implement on the basis of splice eligibility loss, EOF-propagation regression at goodbye, no parent-side simplification, no upstream parity, and the cross-platform asymmetry. Adds a one-line cross-reference in crates/rsync_io/src/ssh/mod.rs so the disposition is discoverable from source.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Testing
https://chatgpt.com/codex/tasks/task_e_69035f181f2083238601ee68426396b3