docs(audits): SSH socketpair vs pipe transport feasibility (#1687)#4193
Merged
Conversation
Narrow-scope audit for the single-FD wire variant (one socketpair shared between the child's fd 0 and fd 1) that #1687 proposes. Complements ssh-socketpair-vs-pipes.md (#1938), which ruled out the two-socketpair-per-direction variant. Recommends do-not-implement on the basis of splice eligibility loss, EOF-propagation regression at goodbye, no parent-side simplification, no upstream parity, and the cross-platform asymmetry. Adds a one-line cross-reference in crates/rsync_io/src/ssh/mod.rs so the disposition is discoverable from source.
github-actions
Bot
added
the
documentation
4 tasks
oferchen
added a commit
that referenced
this pull request
May 18, 2026
…#4193) Narrow-scope audit for the single-FD wire variant (one socketpair shared between the child's fd 0 and fd 1) that #1687 proposes. Complements ssh-socketpair-vs-pipes.md (#1938), which ruled out the two-socketpair-per-direction variant. Recommends do-not-implement on the basis of splice eligibility loss, EOF-propagation regression at goodbye, no parent-side simplification, no upstream parity, and the cross-platform asymmetry. Adds a one-line cross-reference in crates/rsync_io/src/ssh/mod.rs so the disposition is discoverable from source.
oferchen
added a commit
that referenced
this pull request
May 18, 2026
…#4193) Narrow-scope audit for the single-FD wire variant (one socketpair shared between the child's fd 0 and fd 1) that #1687 proposes. Complements ssh-socketpair-vs-pipes.md (#1938), which ruled out the two-socketpair-per-direction variant. Recommends do-not-implement on the basis of splice eligibility loss, EOF-propagation regression at goodbye, no parent-side simplification, no upstream parity, and the cross-platform asymmetry. Adds a one-line cross-reference in crates/rsync_io/src/ssh/mod.rs so the disposition is discoverable from source.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
splice(2)eligibility loss (collides with Restrict limiter test-only re-export #1860), EOF-propagation regression at the rsync goodbye phase (shared-FD half-close does not work when the child holds two refs to the same socket), no parent-side simplification, no upstream parity (upstream uses two socketpairs, not one), and cross-platform asymmetry (Windows has nosocketpair).crates/rsync_io/src/ssh/mod.rspointing at both audits so the disposition is discoverable from source.Files touched
docs/audits/ssh-single-socketpair-bidirectional.md(new audit)crates/rsync_io/src/ssh/mod.rs(doc cross-reference, 10 lines)Test plan