Align filters config test imports with rustfmt#1705
Merged
Conversation
oferchen
added a commit
that referenced
this pull request
Apr 17, 2026
Add upstream self-roundtrip test for compressed batch delta transfers to document the upstream rsync 3.4.1 limitation where the batch format does not record which compression algorithm was used. Upstream's read-batch always forces CPRES_ZLIB (compat.c:194-195), but write-batch may auto-negotiate zstd, producing unreadable batch files. oc-rsync avoids this by recording uncompressed data in batch files (do_compression=false in stream flags). Document this design decision across batch_support.rs, replay.rs, compressed_writer.rs, and flags.rs. Refs: #1705
4 tasks
oferchen
added a commit
that referenced
this pull request
Apr 17, 2026
Add upstream self-roundtrip test for compressed batch delta transfers to document the upstream rsync 3.4.1 limitation where the batch format does not record which compression algorithm was used. Upstream's read-batch always forces CPRES_ZLIB (compat.c:194-195), but write-batch may auto-negotiate zstd, producing unreadable batch files. oc-rsync avoids this by recording uncompressed data in batch files (do_compression=false in stream flags). Document this design decision across batch_support.rs, replay.rs, compressed_writer.rs, and flags.rs. Refs: #1705
oferchen
added a commit
that referenced
this pull request
May 1, 2026
Add upstream self-roundtrip test for compressed batch delta transfers to document the upstream rsync 3.4.1 limitation where the batch format does not record which compression algorithm was used. Upstream's read-batch always forces CPRES_ZLIB (compat.c:194-195), but write-batch may auto-negotiate zstd, producing unreadable batch files. oc-rsync avoids this by recording uncompressed data in batch files (do_compression=false in stream flags). Document this design decision across batch_support.rs, replay.rs, compressed_writer.rs, and flags.rs. Refs: #1705
1 task
oferchen
added a commit
that referenced
this pull request
May 5, 2026
Add upstream self-roundtrip test for compressed batch delta transfers to document the upstream rsync 3.4.1 limitation where the batch format does not record which compression algorithm was used. Upstream's read-batch always forces CPRES_ZLIB (compat.c:194-195), but write-batch may auto-negotiate zstd, producing unreadable batch files. oc-rsync avoids this by recording uncompressed data in batch files (do_compression=false in stream flags). Document this design decision across batch_support.rs, replay.rs, compressed_writer.rs, and flags.rs. Refs: #1705
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Testing
https://chatgpt.com/codex/tasks/task_e_6903864f8a74832385830bbe0c9dd98b