Skip to content

docs(daemon): tcpdump comparison for daemon-side server filter pull (#1697)#3516

Merged
oferchen merged 1 commit into
masterfrom
docs/tcpdump-daemon-server-side-filter-pull-1697
May 1, 2026
Merged

docs(daemon): tcpdump comparison for daemon-side server filter pull (#1697)#3516
oferchen merged 1 commit into
masterfrom
docs/tcpdump-daemon-server-side-filter-pull-1697

Conversation

@oferchen
Copy link
Copy Markdown
Owner

@oferchen oferchen commented May 1, 2026

Summary

Adds docs/audits/tcpdump-daemon-server-side-filter-pull.md, a wire-byte audit comparing upstream rsync 3.4.1 with oc-rsync as a daemon serving a pull when the module has server-side filter directives (filter / exclude / include / exclude from / include from in oc-rsyncd.conf).

Headline: No active wire-byte divergence today. Daemon-side filter rules are applied process-locally on the sender side as the file list is built; they never traverse the wire in either upstream or oc-rsync. The wire surface for phases 1-8 and 11 is byte-equivalent to a daemon configured with no filter directives. Phases 9-10 differ only by absence of filtered entries, with framing unchanged.

Scope

  • Code audit only - no live tcpdump output, no Rust code changes.
  • Pull direction only (daemon = sender, client = receiver). Push is the structural mirror and noted in the "What this audit doesn't cover" section.
  • Server-side rules from oc-rsyncd.conf only; client-side CLI filters are covered by docs/audits/tcpdump-daemon-filter-pull.md.

Tracker

Closes #1697.

Related

Test plan

  • CI checks pass

…1697)

Adds wire-byte audit for server-side filter rules (filter / exclude /
include / exclude from / include from in oc-rsyncd.conf module sections)
during a pull. Headline finding: no active divergence today; daemon
rules are applied process-locally and never serialised. Documents the
load-bearing invariants and divergence sentinels.

Companion to docs/audits/tcpdump-daemon-proto28-29.md (PR #3513) and
docs/daemon/filter-precedence.md (PR #1888).
@github-actions github-actions Bot added the documentation Improvements or additions to documentation label May 1, 2026
@oferchen oferchen merged commit e33a6c4 into master May 1, 2026
12 checks passed
@oferchen oferchen deleted the docs/tcpdump-daemon-server-side-filter-pull-1697 branch May 1, 2026 21:08
oferchen added a commit that referenced this pull request May 5, 2026
…1697) (#3516)

Adds wire-byte audit for server-side filter rules (filter / exclude /
include / exclude from / include from in oc-rsyncd.conf module sections)
during a pull. Headline finding: no active divergence today; daemon
rules are applied process-locally and never serialised. Documents the
load-bearing invariants and divergence sentinels.

Companion to docs/audits/tcpdump-daemon-proto28-29.md (PR #3513) and
docs/daemon/filter-precedence.md (PR #1888).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant