Support daemon alias invocation#2094
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| #[cfg(test)] | ||
| #[allow(unused_imports)] | ||
| pub(crate) use oc_rsync_core::branding::{self as branding, Brand}; | ||
| pub(crate) use oc_rsync_core::branding::{self as branding}; | ||
| #[cfg(test)] | ||
| #[allow(unused_imports)] | ||
| pub(crate) use oc_rsync_core::client::{AddressMode, StrongChecksumChoice, TransferTimeout}; |
There was a problem hiding this comment.
The test modules under crates/cli/src/frontend/tests pull symbols from the parent module via use super::*; and previously relied on the #[cfg(test)] pub(crate) use oc_rsync_core::branding::{self as branding, Brand}; re‑export. This change drops Brand from that re‑export, so files like short.rs and version.rs no longer compile because Brand is undefined. Either keep Brand in the re‑export or import it explicitly in the tests so cargo test -p oc-rsync-cli continues to build.
Useful? React with 👍 / 👎.
Specifies a PID-style controller that resizes per-pipeline I/O buffer windows in response to throughput feedback, layered on top of the existing pressure-driven BufferPool grow/shrink logic. Covers setpoint/PV/MV signals, sample cadence, anti-windup clamp, integration points (disk-commit channel capacity, buffer pool slot size, multiplex frame batching), Ziegler-Nichols tuning strategy, and three workload presets gated behind --adaptive-buffers. Maps to follow-up tasks #2095 (implementation) and #2096 (convergence tests).
Specifies a PID-style controller that resizes per-pipeline I/O buffer windows in response to throughput feedback, layered on top of the existing pressure-driven BufferPool grow/shrink logic. Covers setpoint/PV/MV signals, sample cadence, anti-windup clamp, integration points (disk-commit channel capacity, buffer pool slot size, multiplex frame batching), Ziegler-Nichols tuning strategy, and three workload presets gated behind --adaptive-buffers. Maps to follow-up tasks #2095 (implementation) and #2096 (convergence tests).
Specifies a PID-style controller that resizes per-pipeline I/O buffer windows in response to throughput feedback, layered on top of the existing pressure-driven BufferPool grow/shrink logic. Covers setpoint/PV/MV signals, sample cadence, anti-windup clamp, integration points (disk-commit channel capacity, buffer pool slot size, multiplex frame batching), Ziegler-Nichols tuning strategy, and three workload presets gated behind --adaptive-buffers. Maps to follow-up tasks #2095 (implementation) and #2096 (convergence tests).
1 participant
Summary
Testing
Codex Task