docs(design): adaptive buffer-sizing controller RFC#3948
Merged
Conversation
github-actions
Bot
added
the
documentation
Specifies a PID-style controller that resizes per-pipeline I/O buffer windows in response to throughput feedback, layered on top of the existing pressure-driven BufferPool grow/shrink logic. Covers setpoint/PV/MV signals, sample cadence, anti-windup clamp, integration points (disk-commit channel capacity, buffer pool slot size, multiplex frame batching), Ziegler-Nichols tuning strategy, and three workload presets gated behind --adaptive-buffers. Maps to follow-up tasks #2095 (implementation) and #2096 (convergence tests).
oferchen
force-pushed
the
docs/adaptive-buffer-controller-2094
branch
from
742828e to
a5c3895
Compare
oferchen
added a commit
that referenced
this pull request
May 18, 2026
Specifies a PID-style controller that resizes per-pipeline I/O buffer windows in response to throughput feedback, layered on top of the existing pressure-driven BufferPool grow/shrink logic. Covers setpoint/PV/MV signals, sample cadence, anti-windup clamp, integration points (disk-commit channel capacity, buffer pool slot size, multiplex frame batching), Ziegler-Nichols tuning strategy, and three workload presets gated behind --adaptive-buffers. Maps to follow-up tasks #2095 (implementation) and #2096 (convergence tests).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
docs/design/adaptive-buffer-controller.md, a 298-line RFC for task Support daemon alias invocation #2094 specifying a PID-style controller that resizes per-pipeline I/O buffer windows from observed throughput.BufferPoolgrow/shrink path (Fix cargo-deb asset detection for packaged binaries #1638-Split negotiation buffered-prefix tests and add Windows x86 cross build #1641) by observing throughput (orthogonal to allocation pressure) and acting on slot size (orthogonal to slot count).crates/transfer/src/disk_commit/,crates/engine/src/local_copy/buffer_pool/, andcrates/protocol/src/multiplex/writer.rs, with the controller itself living in a newcrates/engine/src/pipeline/buffer_controller.rs.--max-allocsaturation, and Ziegler-Nichols-derived defaults for LAN / WAN / throttled workload presets gated behind--adaptive-buffers(companion to Brand version banners around oc-rsync #2093).Test plan