Skip to content

Use release tarball for interop harness upstream builds#2118

Merged
oferchen merged 1 commit into
masterfrom
compare-protocol-implementation-to-rsync-v3.4.1
Nov 9, 2025
Merged

Use release tarball for interop harness upstream builds#2118
oferchen merged 1 commit into
masterfrom
compare-protocol-implementation-to-rsync-v3.4.1

Conversation

@oferchen
Copy link
Copy Markdown
Owner

@oferchen oferchen commented Nov 9, 2025

Summary

  • ensure the interop harness requires tar so it can unpack upstream sources
  • download rsync release tarballs before falling back to cloning with git
  • keep git-based fetching as a fallback when the tarball retrieval fails

Testing

  • bash tools/ci/run_interop.sh (fails: upstream clients timed out waiting for delegated transfers)

Codex Task

@oferchen oferchen merged commit 3c31efd into master Nov 9, 2025
@oferchen oferchen deleted the compare-protocol-implementation-to-rsync-v3.4.1 branch November 9, 2025 12:35
oferchen added a commit that referenced this pull request May 7, 2026
)

Document which io_uring read/write SQEs use READ_FIXED/WRITE_FIXED today,
which still pay per-op page pinning, and the bench plan plus
recommendation for the >= 64 KiB hot path.
oferchen added a commit that referenced this pull request May 17, 2026
…ern (#4320)

The post-#4310 tests.rs at 882 lines exceeded the 650-line cap. Split
into a tests/ directory grouped by concern, each file well under cap:

- tests/mod.rs (39) - shared try_ring / try_group helpers and module decls.
- tests/registry.rs (113) - page size, validation guards, slot allocator.
- tests/submit.rs (179) - submit_read/write_fixed_batch helpers.
- tests/stats.rs (141) - acquire/miss counters and snapshot semantics.
- tests/status.rs (49) - try_new_with_status outcome reporting.
- tests/drop_contract.rs (309) - Drop semantics and constrained-env coverage
  for the PR #4022 / task #2118 fixed-buffer invariants audit.

The try_ring / try_group helpers replace the repeated match-or-return
boilerplate that handled environments where io_uring is unavailable
(CI sandboxes, seccomp, kernel < 5.6).

No behavioural change; test coverage is preserved.
oferchen added a commit that referenced this pull request May 18, 2026
)

Document which io_uring read/write SQEs use READ_FIXED/WRITE_FIXED today,
which still pay per-op page pinning, and the bench plan plus
recommendation for the >= 64 KiB hot path.
oferchen added a commit that referenced this pull request May 18, 2026
…ern (#4320)

The post-#4310 tests.rs at 882 lines exceeded the 650-line cap. Split
into a tests/ directory grouped by concern, each file well under cap:

- tests/mod.rs (39) - shared try_ring / try_group helpers and module decls.
- tests/registry.rs (113) - page size, validation guards, slot allocator.
- tests/submit.rs (179) - submit_read/write_fixed_batch helpers.
- tests/stats.rs (141) - acquire/miss counters and snapshot semantics.
- tests/status.rs (49) - try_new_with_status outcome reporting.
- tests/drop_contract.rs (309) - Drop semantics and constrained-env coverage
  for the PR #4022 / task #2118 fixed-buffer invariants audit.

The try_ring / try_group helpers replace the repeated match-or-return
boilerplate that handled environments where io_uring is unavailable
(CI sandboxes, seccomp, kernel < 5.6).

No behavioural change; test coverage is preserved.
oferchen added a commit that referenced this pull request May 18, 2026
…ern (#4320)

The post-#4310 tests.rs at 882 lines exceeded the 650-line cap. Split
into a tests/ directory grouped by concern, each file well under cap:

- tests/mod.rs (39) - shared try_ring / try_group helpers and module decls.
- tests/registry.rs (113) - page size, validation guards, slot allocator.
- tests/submit.rs (179) - submit_read/write_fixed_batch helpers.
- tests/stats.rs (141) - acquire/miss counters and snapshot semantics.
- tests/status.rs (49) - try_new_with_status outcome reporting.
- tests/drop_contract.rs (309) - Drop semantics and constrained-env coverage
  for the PR #4022 / task #2118 fixed-buffer invariants audit.

The try_ring / try_group helpers replace the repeated match-or-return
boilerplate that handled environments where io_uring is unavailable
(CI sandboxes, seccomp, kernel < 5.6).

No behavioural change; test coverage is preserved.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant