refactor(fast_io): split io_uring/registered_buffers/tests.rs by concern (LoC followup)#4320
Merged
Merged
Conversation
The post-#4310 tests.rs at 882 lines exceeded the 650-line cap. Split into a tests/ directory grouped by concern, each file well under cap: - tests/mod.rs (39) - shared try_ring / try_group helpers and module decls. - tests/registry.rs (113) - page size, validation guards, slot allocator. - tests/submit.rs (179) - submit_read/write_fixed_batch helpers. - tests/stats.rs (141) - acquire/miss counters and snapshot semantics. - tests/status.rs (49) - try_new_with_status outcome reporting. - tests/drop_contract.rs (309) - Drop semantics and constrained-env coverage for the PR #4022 / task #2118 fixed-buffer invariants audit. The try_ring / try_group helpers replace the repeated match-or-return boilerplate that handled environments where io_uring is unavailable (CI sandboxes, seccomp, kernel < 5.6). No behavioural change; test coverage is preserved.
oferchen
added a commit
that referenced
this pull request
May 18, 2026
…ern (#4320) The post-#4310 tests.rs at 882 lines exceeded the 650-line cap. Split into a tests/ directory grouped by concern, each file well under cap: - tests/mod.rs (39) - shared try_ring / try_group helpers and module decls. - tests/registry.rs (113) - page size, validation guards, slot allocator. - tests/submit.rs (179) - submit_read/write_fixed_batch helpers. - tests/stats.rs (141) - acquire/miss counters and snapshot semantics. - tests/status.rs (49) - try_new_with_status outcome reporting. - tests/drop_contract.rs (309) - Drop semantics and constrained-env coverage for the PR #4022 / task #2118 fixed-buffer invariants audit. The try_ring / try_group helpers replace the repeated match-or-return boilerplate that handled environments where io_uring is unavailable (CI sandboxes, seccomp, kernel < 5.6). No behavioural change; test coverage is preserved.
oferchen
added a commit
that referenced
this pull request
May 18, 2026
…ern (#4320) The post-#4310 tests.rs at 882 lines exceeded the 650-line cap. Split into a tests/ directory grouped by concern, each file well under cap: - tests/mod.rs (39) - shared try_ring / try_group helpers and module decls. - tests/registry.rs (113) - page size, validation guards, slot allocator. - tests/submit.rs (179) - submit_read/write_fixed_batch helpers. - tests/stats.rs (141) - acquire/miss counters and snapshot semantics. - tests/status.rs (49) - try_new_with_status outcome reporting. - tests/drop_contract.rs (309) - Drop semantics and constrained-env coverage for the PR #4022 / task #2118 fixed-buffer invariants audit. The try_ring / try_group helpers replace the repeated match-or-return boilerplate that handled environments where io_uring is unavailable (CI sandboxes, seccomp, kernel < 5.6). No behavioural change; test coverage is preserved.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #4310. The post-decomposition
registered_buffers/tests.rswas 882 lines, over the 650-line cap enforced bytools/enforce_limits.sh. Split into atests/directory grouped by concern, each file well under the cap.tests/mod.rstry_ring/try_grouphelpers, submodule declstests/registry.rstests/submit.rssubmit_read_fixed_batch/submit_write_fixed_batchtests/stats.rsmiss_ratemath, snapshotstests/status.rstry_new_with_statusoutcome reportingtests/drop_contract.rsThe new
try_ring/try_grouphelpers replace the repeated match-or-return boilerplate that handled environments where io_uring is unavailable (CI sandboxes, seccomp, kernel < 5.6). No behavioural change; test coverage is preserved.Test plan
cargo fmt --all -- --checkpasses.cargo check -p fast_io --features io_uring --testscompiles cleanly.cargo nextest run -p fast_io --features io_uring -E 'test(registered_buffers)'passes on Linux runners with io_uring available.