test: add DeleteStats write/read roundtrip tests#2565
Merged
Conversation
Add wire format roundtrip tests for DeleteStats: - Zero values roundtrip - Realistic values roundtrip - Large values roundtrip - total() computation correctness
oferchen
added a commit
that referenced
this pull request
May 1, 2026
Add wire format roundtrip tests for DeleteStats: - Zero values roundtrip - Realistic values roundtrip - Large values roundtrip - total() computation correctness
oferchen
added a commit
that referenced
this pull request
May 5, 2026
Add wire format roundtrip tests for DeleteStats: - Zero values roundtrip - Realistic values roundtrip - Large values roundtrip - total() computation correctness
2 tasks
oferchen
added a commit
that referenced
this pull request
May 21, 2026
…PIP-3+5 wire-up (#4677) Combined closure note covering three trackers whose deliverables have already shipped or were absorbed into existing design surface: - PIP-2 (#2565): the design doc was supposed to describe the token_loop -> ParallelDeltaApplier migration. That document already exists as docs/design/parallel-receive-delta-default-on.md (shipped in PR #4319 scaffold, extended by PR #4666 default-on flip). Marked completed retroactively. - FFB-3 (#2576): conditional task that only activated if FFB-1 chose Option A or B. FFB-1 (PR #4659) chose Option D - barrier baked into finish_file - so every existing caller already gets the barrier without callsite migration. Marked deferred N-A. - FFB-4 (#2577): explicit flush_workers call at the PIP-3 wire-up site. PIP-3 + PIP-5 (PR #4666 merged) routes through finish_file, which already barriers via Option D. No explicit call needed. Marked satisfied-by-design. Note: FFB-2 implementation (PR #4665, in CI) needed a spin-then-yield fix around finish_file's try_unwrap to close a Windows release-race; future work to restructure DecrementGuard would be FFB-5+ if filed. No source changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
DeleteStats::write_to()/read_from()total()computation correctnessTest plan