Skip to content

docs(design): close FFB-3/FFB-4/PIP-2 as satisfied by FFB-1 design + PIP-3+5 wire-up#4677

Merged
oferchen merged 1 commit into
masterfrom
docs/design-ffb-3-4-pip-2-closure
May 21, 2026
Merged

docs(design): close FFB-3/FFB-4/PIP-2 as satisfied by FFB-1 design + PIP-3+5 wire-up#4677
oferchen merged 1 commit into
masterfrom
docs/design-ffb-3-4-pip-2-closure

Conversation

@oferchen
Copy link
Copy Markdown
Owner

Summary

Combined closure note for three task chains whose deliverables have
already shipped (or were absorbed into existing design surface).

Followup note in the doc: the FFB-2 implementation required a
spin-then-yield fix around finish_file's Arc::try_unwrap to close a
Windows release-race (tracked in
project_slothandle_decrementguard_release_race.md). Restructuring
DecrementGuard to eliminate the spin would be FFB-5+ if filed.

Doc: docs/design/ffb-3-4-pip-2-closure-2026-05-21.md (145 lines,
markdown only, no source changes).

Test plan

…PIP-3+5 wire-up

Combined closure note covering three trackers whose deliverables have
already shipped or were absorbed into existing design surface:

- PIP-2 (#2565): the design doc was supposed to describe the
  token_loop -> ParallelDeltaApplier migration. That document already
  exists as docs/design/parallel-receive-delta-default-on.md
  (shipped in PR #4319 scaffold, extended by PR #4666 default-on
  flip). Marked completed retroactively.
- FFB-3 (#2576): conditional task that only activated if FFB-1 chose
  Option A or B. FFB-1 (PR #4659) chose Option D - barrier baked into
  finish_file - so every existing caller already gets the barrier
  without callsite migration. Marked deferred N-A.
- FFB-4 (#2577): explicit flush_workers call at the PIP-3 wire-up
  site. PIP-3 + PIP-5 (PR #4666 merged) routes through finish_file,
  which already barriers via Option D. No explicit call needed.
  Marked satisfied-by-design.

Note: FFB-2 implementation (PR #4665, in CI) needed a spin-then-yield
fix around finish_file's try_unwrap to close a Windows release-race;
future work to restructure DecrementGuard would be FFB-5+ if filed.

No source changes.
@oferchen oferchen merged commit 2937b3a into master May 21, 2026
10 checks passed
@github-actions github-actions Bot added the documentation Improvements or additions to documentation label May 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant