docs(daemon): RFC for tokio-based async listener behind async-daemon feature (#1934)#3524
Merged
Merged
Conversation
…feature (#1934) Adds docs/audits/daemon-async-listener-rfc.md sketching a feature-gated tokio-based async accept loop for the daemon. The accept loop and greeting/module-select phase run on the tokio runtime; the transfer hot path stays synchronous behind a spawn_blocking hand-off, keeping tokio scoped to the daemon crate per the #1779 / #1818 policy. Design only - implementation lands in #1935.
github-actions
Bot
added
the
documentation
oferchen
added a commit
that referenced
this pull request
May 5, 2026
…feature (#1934) (#3524) Adds docs/audits/daemon-async-listener-rfc.md sketching a feature-gated tokio-based async accept loop for the daemon. The accept loop and greeting/module-select phase run on the tokio runtime; the transfer hot path stays synchronous behind a spawn_blocking hand-off, keeping tokio scoped to the daemon crate per the #1779 / #1818 policy. Design only - implementation lands in #1935.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1934.
Summary
Adds
docs/audits/daemon-async-listener-rfc.md, a design RFC sketching a feature-gated tokio-based async accept loop for the oc-rsync daemon. The new path lives behind a--features async-daemonCargo feature on thedaemoncrate and is off by default.@RSYNCD:greeting / module-select phase only.tokio::net::TcpStreamis converted viainto_std()and handed totokio::task::spawn_blocking, which calls the existing synchronoushandle_sessionbody unchanged.daemoncrate (andcore's existing optionalasyncfeature) per the tokio-scope policy from Modularize CLI drive orchestration helpers #1779 / Fix Windows PATHEXT parsing for fallback binary search #1818. Sender, receiver, generator,core::session, and theengine/protocol/transfercrates do not become async.The RFC complements the existing audit at
docs/audits/async-daemon-listener.md; the two are consistent and cross-reference each other.Test plan
crates/<crate>/src/<path>:<line>from files read while drafting.target/interop/upstream-src/rsync-3.4.1/.