Modularize CLI drive orchestration helpers#1779
Merged
Merged
Conversation
This was referenced May 1, 2026
oferchen
added a commit
that referenced
this pull request
May 1, 2026
…feature (#1934) (#3524) Adds docs/audits/daemon-async-listener-rfc.md sketching a feature-gated tokio-based async accept loop for the daemon. The accept loop and greeting/module-select phase run on the tokio runtime; the transfer hot path stays synchronous behind a spawn_blocking hand-off, keeping tokio scoped to the daemon crate per the #1779 / #1818 policy. Design only - implementation lands in #1935.
oferchen
added a commit
that referenced
this pull request
May 5, 2026
…feature (#1934) (#3524) Adds docs/audits/daemon-async-listener-rfc.md sketching a feature-gated tokio-based async accept loop for the daemon. The accept loop and greeting/module-select phase run on the tokio runtime; the transfer hot path stays synchronous behind a spawn_blocking hand-off, keeping tokio scoped to the daemon crate per the #1779 / #1818 policy. Design only - implementation lands in #1935.
3 tasks
oferchen
added a commit
that referenced
this pull request
May 5, 2026
Re-checks the tokio scope established by audit #1779 against the current Cargo.toml set after #1732 (async became default) and #1818. Documents drift to seven allowed consumers (daemon, core, engine, transfer, bandwidth, protocol, rsync_io), proves the public async surface stays in those crates, and proposes a CI guardrail script to pin the boundary.
This was referenced May 7, 2026
4 tasks
oferchen
added a commit
that referenced
this pull request
May 16, 2026
Expand the placeholder async migration plan into a comprehensive, opinionated design covering: current synchronous threading model per subsystem, per-subsystem cost/benefit, a phased incremental adoption strategy, tokio runtime choice with rejected alternatives, sync/async bridge patterns, backward-compat strategy, risk register, and open questions. Cross-references existing async-related tasks (#1367, #1411, #1591, #1593, #1595, #1674, #1751, #1779, #1780, #1782, #1796, #1797, #1805, #1806, #1889, #1890, #1891, #1892, #1934, #1935, #2136) and related design notes so future planners have a single anchor.
oferchen
added a commit
that referenced
this pull request
May 16, 2026
Expand the placeholder async migration plan into a comprehensive, opinionated design covering: current synchronous threading model per subsystem, per-subsystem cost/benefit, a phased incremental adoption strategy, tokio runtime choice with rejected alternatives, sync/async bridge patterns, backward-compat strategy, risk register, and open questions. Cross-references existing async-related tasks (#1367, #1411, #1591, #1593, #1595, #1674, #1751, #1779, #1780, #1782, #1796, #1797, #1805, #1806, #1889, #1890, #1891, #1892, #1934, #1935, #2136) and related design notes so future planners have a single anchor.
oferchen
added a commit
that referenced
this pull request
May 18, 2026
Re-checks the tokio scope established by audit #1779 against the current Cargo.toml set after #1732 (async became default) and #1818. Documents drift to seven allowed consumers (daemon, core, engine, transfer, bandwidth, protocol, rsync_io), proves the public async surface stays in those crates, and proposes a CI guardrail script to pin the boundary.
oferchen
added a commit
that referenced
this pull request
May 18, 2026
Expand the placeholder async migration plan into a comprehensive, opinionated design covering: current synchronous threading model per subsystem, per-subsystem cost/benefit, a phased incremental adoption strategy, tokio runtime choice with rejected alternatives, sync/async bridge patterns, backward-compat strategy, risk register, and open questions. Cross-references existing async-related tasks (#1367, #1411, #1591, #1593, #1595, #1674, #1751, #1779, #1780, #1782, #1796, #1797, #1805, #1806, #1889, #1890, #1891, #1892, #1934, #1935, #2136) and related design notes so future planners have a single anchor.
oferchen
added a commit
that referenced
this pull request
May 18, 2026
Expand the placeholder async migration plan into a comprehensive, opinionated design covering: current synchronous threading model per subsystem, per-subsystem cost/benefit, a phased incremental adoption strategy, tokio runtime choice with rejected alternatives, sync/async bridge patterns, backward-compat strategy, risk register, and open questions. Cross-references existing async-related tasks (#1367, #1411, #1591, #1593, #1595, #1674, #1751, #1779, #1780, #1782, #1796, #1797, #1805, #1806, #1889, #1890, #1891, #1892, #1934, #1935, #2136) and related design notes so future planners have a single anchor.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Testing
https://chatgpt.com/codex/tasks/task_e_69051ca2bf2c83238f6c3ad24b3b95b8