docs(design): daemon thread-per-connection benchmark plan (#1933)#3713
Merged
Conversation
Defines the empirical benchmark harness, workloads (100 / 1k / 10k concurrent clients), metrics, soft-limit triggers, comparison oracle against upstream rsync 3.4.1, and the decision criteria that gate the async listener migration tracked under #1935. Frames the active-counter fix from the parent audit (#1673, PR #3705) as a strict precondition. Tracking: oc-rsync task #1933.
oferchen
force-pushed
the
docs/daemon-tpc-benchmark-1933
branch
from
a0c7f0b to
c839446
Compare
oferchen
added a commit
that referenced
this pull request
May 18, 2026
) Defines the empirical benchmark harness, workloads (100 / 1k / 10k concurrent clients), metrics, soft-limit triggers, comparison oracle against upstream rsync 3.4.1, and the decision criteria that gate the async listener migration tracked under #1935. Frames the active-counter fix from the parent audit (#1673, PR #3705) as a strict precondition. Tracking: oc-rsync task #1933.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
docs/design/daemon-tpc-benchmark-plan.md(460 lines) - empirical follow-up plan to the static analysis indocs/audits/daemon-thread-per-connection-scalability.md(task Split branding tests into module #1673, PR docs(audits): daemon thread-per-connection scalability audit (#1673) #3705).crates/daemon/benches/daemon_benchmark.rswith a Rust client driver and resource sampler), workloads at 100 / 1 000 / 10 000 concurrent clients pulling 100 small files each, metrics, soft-limit triggers, and the comparison matrix against upstream rsync 3.4.1.max_sessionsenforces total served, not active concurrent (crates/daemon/src/daemon/sections/server_runtime/connection.rs:264-270,connection.rs:352-358); without that fix W10k is uninstrumentable.Test plan
crates/daemon/src/daemon/sections/server_runtime/,module_state/runtime.rs,module_state/connection_limiter.rs,sections/greeting.rs.Tracking: oc-rsync task #1933.