Split branding tests into module#1673
Closed
oferchen wants to merge 1 commit into
Closed
Conversation
This was referenced May 5, 2026
oferchen
added a commit
that referenced
this pull request
May 5, 2026
Defines the empirical benchmark harness, workloads (100 / 1k / 10k concurrent clients), metrics, soft-limit triggers, comparison oracle against upstream rsync 3.4.1, and the decision criteria that gate the async listener migration tracked under #1935. Frames the active-counter fix from the parent audit (#1673, PR #3705) as a strict precondition. Tracking: oc-rsync task #1933.
oferchen
added a commit
that referenced
this pull request
May 5, 2026
Static analysis of the daemon's accept loop, per-connection resource cost, hard and soft limits, lock contention surface, and the migration sequencing against the async listener RFC. Frames the empirical follow-up benchmark at 100, 1000, and 10000 concurrent connections. Tracking: oc-rsync task #1673.
oferchen
added a commit
that referenced
this pull request
May 5, 2026
) Defines the empirical benchmark harness, workloads (100 / 1k / 10k concurrent clients), metrics, soft-limit triggers, comparison oracle against upstream rsync 3.4.1, and the decision criteria that gate the async listener migration tracked under #1935. Frames the active-counter fix from the parent audit (#1673, PR #3705) as a strict precondition. Tracking: oc-rsync task #1933.
This was referenced May 7, 2026
oferchen
added a commit
that referenced
this pull request
May 7, 2026
#3895) Replace the thread-per-connection audit with a focused 5-section brief covering the accept loop in crates/daemon/src/daemon/sections/server_runtime/accept_loop.rs, the per-thread stack and per-session memory ceiling, the fork-vs-thread trade vs upstream rsyncd, slowloris and lock-contention failure modes, and the migration path through tokio listener (#1934/#1935), daemon-level max_connections, and bounded worker pools.
oferchen
added a commit
that referenced
this pull request
May 14, 2026
…n gap (#1673) (#4023) Distil the existing thread-per-connection analysis into a single-page audit with a concrete threshold table (100/1k/10k) and one recommendation: a daemon-level max-connections admission cap that reads the already-wired ConnectionCounter before thread::spawn and returns upstream's @error: max connections (N) reached.
oferchen
added a commit
that referenced
this pull request
May 18, 2026
Static analysis of the daemon's accept loop, per-connection resource cost, hard and soft limits, lock contention surface, and the migration sequencing against the async listener RFC. Frames the empirical follow-up benchmark at 100, 1000, and 10000 concurrent connections. Tracking: oc-rsync task #1673.
oferchen
added a commit
that referenced
this pull request
May 18, 2026
) Defines the empirical benchmark harness, workloads (100 / 1k / 10k concurrent clients), metrics, soft-limit triggers, comparison oracle against upstream rsync 3.4.1, and the decision criteria that gate the async listener migration tracked under #1935. Frames the active-counter fix from the parent audit (#1673, PR #3705) as a strict precondition. Tracking: oc-rsync task #1933.
oferchen
added a commit
that referenced
this pull request
May 18, 2026
#3895) Replace the thread-per-connection audit with a focused 5-section brief covering the accept loop in crates/daemon/src/daemon/sections/server_runtime/accept_loop.rs, the per-thread stack and per-session memory ceiling, the fork-vs-thread trade vs upstream rsyncd, slowloris and lock-contention failure modes, and the migration path through tokio listener (#1934/#1935), daemon-level max_connections, and bounded worker pools.
oferchen
added a commit
that referenced
this pull request
May 18, 2026
…n gap (#1673) (#4023) Distil the existing thread-per-connection analysis into a single-page audit with a concrete threshold table (100/1k/10k) and one recommendation: a daemon-level max-connections admission cap that reads the already-wired ConnectionCounter before thread::spawn and returns upstream's @error: max connections (N) reached.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Testing
https://chatgpt.com/codex/tasks/task_e_6903503a75a88323be2cb421f2c3f35c