docs(audits): daemon thread-per-connection scalability ceiling (#1673)#3895
Merged
Conversation
Replace the thread-per-connection audit with a focused 5-section brief covering the accept loop in crates/daemon/src/daemon/sections/server_runtime/accept_loop.rs, the per-thread stack and per-session memory ceiling, the fork-vs-thread trade vs upstream rsyncd, slowloris and lock-contention failure modes, and the migration path through tokio listener (#1934/#1935), daemon-level max_connections, and bounded worker pools.
oferchen
added a commit
that referenced
this pull request
May 18, 2026
#3895) Replace the thread-per-connection audit with a focused 5-section brief covering the accept loop in crates/daemon/src/daemon/sections/server_runtime/accept_loop.rs, the per-thread stack and per-session memory ceiling, the fork-vs-thread trade vs upstream rsyncd, slowloris and lock-contention failure modes, and the migration path through tokio listener (#1934/#1935), daemon-level max_connections, and bounded worker pools.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
docs/audits/daemon-thread-per-connection.mdwith a focused, 116-line static audit covering the daemon accept loop and connection lifecycle.crates/daemon/src/daemon/sections/server_runtime/, quantify per-session memory (BufferPool, ReorderBuffer, flist) and the ~30 k-thread Linux ceiling, and contrast oc-rsync's thread+catch_unwindmodel with upstream rsyncd's fork-per-conn process boundary.max connectionsenforcement on the existingConnectionCounter, connection rate limit, bounded worker pool, reduced stack size.Test plan
wc -l).accept_loop.rs,connection.rs,workers.rs,connection_counter.rs.