feat: wire io_uring RENAMEAT2 and LINKAT into production paths#3981
Merged
Conversation
Wire the existing IORING_OP_RENAMEAT (task #1920) and IORING_OP_LINKAT (task #1921) opcode wrappers into the temp-file commit and hardlink finalization paths respectively. On Linux 5.11+ with io_uring available, temp-file renames in DestinationWriteGuard::commit_named_temp_file() now submit an IORING_OP_RENAMEAT SQE instead of a synchronous rename(2) syscall. On Linux 5.15+ with io_uring available, hardlink creation in HardlinkApplyTracker, create_hard_link(), and the --link-dest path now submit an IORING_OP_LINKAT SQE instead of a synchronous link(2). Both paths fall back transparently to std::fs::rename / std::fs::hard_link on non-Linux platforms, older kernels, or when io_uring is disabled. Two new convenience functions in fast_io expose the try-or-fallback pattern: try_rename_via_io_uring() and try_hard_link_via_io_uring(), returning Option<io::Result<()>> so callers can fall through to the portable implementation when None is returned. Closes #1924, closes #1925.
8 tasks
oferchen
added a commit
that referenced
this pull request
May 18, 2026
Wire the existing IORING_OP_RENAMEAT (task #1920) and IORING_OP_LINKAT (task #1921) opcode wrappers into the temp-file commit and hardlink finalization paths respectively. On Linux 5.11+ with io_uring available, temp-file renames in DestinationWriteGuard::commit_named_temp_file() now submit an IORING_OP_RENAMEAT SQE instead of a synchronous rename(2) syscall. On Linux 5.15+ with io_uring available, hardlink creation in HardlinkApplyTracker, create_hard_link(), and the --link-dest path now submit an IORING_OP_LINKAT SQE instead of a synchronous link(2). Both paths fall back transparently to std::fs::rename / std::fs::hard_link on non-Linux platforms, older kernels, or when io_uring is disabled. Two new convenience functions in fast_io expose the try-or-fallback pattern: try_rename_via_io_uring() and try_hard_link_via_io_uring(), returning Option<io::Result<()>> so callers can fall through to the portable implementation when None is returned. Closes #1924, closes #1925.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
IORING_OP_RENAMEAT(kernel 5.11+) into the temp-file commit path (DestinationWriteGuard::commit_named_temp_file), replacing synchronousrename(2)when io_uring is availableIORING_OP_LINKAT(kernel 5.15+) into all hardlink creation paths (HardlinkApplyTracker::apply_follower,resolve_deferred,create_hard_linkoverride, and--link-destlinking), replacing synchronouslink(2)when io_uring is availabletry_rename_via_io_uring()andtry_hard_link_via_io_uring()convenience functions tofast_iothat returnOption<io::Result<()>>for transparent fallbackstd::fs::rename/std::fs::hard_linkon non-Linux, older kernels, or when io_uring is disabled#[cfg]-gated implementations returnNoneon non-Linux; no compilation impact on macOS/WindowsCloses #1924, closes #1925.
Test plan
cargo fmt --all -- --checkpassescargo clippy --workspace --all-targets --all-features --no-deps -- -D warningspassesfast_io:io_uring_rename_dispatch_tests,io_uring_hard_link_dispatch_testsengine:io_uring_rename_dispatch(guard),io_uring_linkat_dispatch_tests(hard_links)