feat(transfer): wire IORING_OP_RENAMEAT2 into remaining temp-file commit paths (#1924)#4002
Merged
Merged
Conversation
…it paths The disk_commit pipelined path and engine guard already use try_rename_via_io_uring for temp-file commits. Two synchronous transfer paths still used plain fs::rename - the non-pipelined response processor and the receiver transfer loop. Wire the same io_uring RENAMEAT2 dispatch into both so all temp-file renames benefit from io_uring on Linux 5.11+.
oferchen
added a commit
that referenced
this pull request
May 18, 2026
…it paths (#4002) The disk_commit pipelined path and engine guard already use try_rename_via_io_uring for temp-file commits. Two synchronous transfer paths still used plain fs::rename - the non-pipelined response processor and the receiver transfer loop. Wire the same io_uring RENAMEAT2 dispatch into both so all temp-file renames benefit from io_uring on Linux 5.11+.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
fast_io::try_rename_via_io_uring()into the two remaining synchronous temp-file commit paths that still used plainstd::fs::rename():transfer_ops::response::process_file_response()- non-pipelined receiver pathreceiver::transfer- synchronous receiver transfer loopIORING_OP_RENAMEATinstead of synchronousrename(2)in all transfer pathsstd::fs::renameon non-Linux, older kernels, or when io_uring is disabledTest plan
cargo fmt --all -- --checkpassescargo clippy --workspace --all-targets --all-features --no-deps -- -D warningspassesrename_with_io_uring_fallbackandtry_rename_via_io_uringunit tests indisk_commit/process.rsandfast_io/src/lib.rscontinue to pass