feat: scope --info=no/-<flag> negation to internal use only#4060
Merged
Conversation
Upstream rsync 3.4.1's parse_output_words (options.c:427) does not implement the `no<flag>` or `-<flag>` negation prefixes; it relies on the `flag0` suffix form documented in rsync.1.md. The parser continues to accept both prefix forms for backwards compatibility and to tolerate server-mode token forwarding, but the user-facing `--info=help` output no longer advertises them so users do not come to depend on a non-portable spelling. Resolves I13 in docs/audits/info-flags-verbosity-matrix.md.
…nternal-only-2167 # Conflicts: # crates/cli/src/frontend/execution/flags/info.rs
oferchen
added a commit
that referenced
this pull request
May 18, 2026
Upstream rsync 3.4.1's parse_output_words (options.c:427) does not implement the `no<flag>` or `-<flag>` negation prefixes; it relies on the `flag0` suffix form documented in rsync.1.md. The parser continues to accept both prefix forms for backwards compatibility and to tolerate server-mode token forwarding, but the user-facing `--info=help` output no longer advertises them so users do not come to depend on a non-portable spelling. Resolves I13 in docs/audits/info-flags-verbosity-matrix.md.
oferchen
added a commit
that referenced
this pull request
May 18, 2026
Upstream rsync 3.4.1's parse_output_words (options.c:427) does not implement the `no<flag>` or `-<flag>` negation prefixes; it relies on the `flag0` suffix form documented in rsync.1.md. The parser continues to accept both prefix forms for backwards compatibility and to tolerate server-mode token forwarding, but the user-facing `--info=help` output no longer advertises them so users do not come to depend on a non-portable spelling. Resolves I13 in docs/audits/info-flags-verbosity-matrix.md.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
parse_output_words(options.c:427) does not implement theno<flag>or-<flag>negation prefixes for--info=. The supported user-facing spelling is the suffix form (e.g.--info=progress0,--info=stats0).--info=helpoutput no longer advertises them.parse_flag_and_leveldocumenting the internal-only status and added tests that pin both the help-text scrub and the parser's continued acceptance of the prefix forms.docs/audits/info-flags-verbosity-matrix.mdto mark I13 RESOLVED.Resolves #2167.
Test plan
cargo nextest run -p cli --all-features -E 'test(info_flag)'passes in CIcargo nextest run -p cli --all-features -E 'test(info_help)'passes in CI