chore(ci): lint scripts/ + ignore S603/S607 in scripts/**#48
Merged
Conversation
Two related fixes that surfaced when the rebased Step 1.1c PR (#46) ran CI for the first time after #47 merged: 1. `scripts/check_schema_drift.py` (added in #47) tripped ruff S603 + S607 — bandit subprocess rules. Dev tooling under scripts/ invokes known executables (git, uv) with fixed argument lists, mirroring the existing T201 carve-out for stdout/stderr. Extend the per-file ignore so this class of script doesn't need scattered `# noqa` comments. 2. The `python` paths-filter that gates `Lint & Test` did not include `scripts/**`. That's why #47's CI passed without exercising ruff on the new script — the lint job was skipped entirely. Add `scripts/**` so future changes under scripts/ are linted at PR time. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two related fixes that surfaced when the rebased Step 1.1c PR (#46) ran CI for the first time after #47 merged:
Ruff S603/S607 in
scripts/check_schema_drift.py(added by chore(schemas): track generated JSON Schemas + add drift CI gate #47) — bandit subprocess rules. Dev tooling underscripts/invokes known executables (git,uv) with fixed argument lists, mirroring the existingT201carve-out for stdout/stderr. Extend the per-file ignore so this class of script doesn't need scattered# noqacomments.scripts/**was missing from thepythonpaths-filter in.github/workflows/ci.yml. That's why chore(schemas): track generated JSON Schemas + add drift CI gate #47's CI passed without exercising ruff on the new script — theLint & Testmatrix was skipped entirely. Addscripts/**so future script changes are linted at PR time.Why now
#46 (1.1c) is currently red because of (1). Landing this fix unblocks the rebase. (2) is the root cause that lets this whole class of bug recur — fixing it here avoids the same surprise on the next script-only PR.
Test plan
Lint & Testand passes (scripts/**now in filter)scripts/check_schema_drift.py🤖 Generated with Claude Code