feat(parser-react): portals & toasts (A9) — Gate 2 complete, Phase 2 done#17
Merged
Merged
Conversation
…done Step 2.5 (TRACKER). Failure mode A9; closes Phase 2: - createPortal components flagged 'portal': the screenshot's DOM position won't match the render tree, but matching already surfaces both the modal (its text) and the trigger site (its instance list). - Toast adapters (react-hot-toast toast/toast.*, notistack enqueueSnackbar, antd message.*): string arguments become renderedText entries with source 'portal' on the CALLING component — 'Order deleted' exists only as a call argument, and now matches its trigger. - Prop-flow correction the fixture forced: function-valued props and on[A-Z] attributes are callbacks, not data — the fetch inside onConfirm no longer emits provides-data. The DELETE still reaches the dialog's lineage the RIGHT way: through the 2.3 handler chain (onClick:onConfirm --triggers--> DELETE /api/orders/selected). - Scorecard: 137 pass / 0 fail; precision/recall 1.000. 88 unit tests. GATE 2 PASSES — Phase 2 (instance graph & cross-file data flow) complete. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TRACKER Step 2.5 — failure mode A9, and the close of Phase 2 (Gate 2).
What's in it
createPortalusers getflags: ["portal"]: a screenshot of the dialog shows nothing from its trigger's DOM subtree, and agents should know the DOM position won't match the render tree. Matching already surfaces both sides: the modal's text →ConfirmDialog, whose instance list points at theOrdersToolbartrigger site.toast("Order deleted")(react-hot-toast, notistackenqueueSnackbar, antdmessage.*): the string exists only as a call argument, rendered by a<Toaster/>mounted elsewhere. It now becomes arenderedTextentry withsource: "portal"on the calling component — a screenshot of the toast matches its trigger.onConfirm={handleConfirm}) andon[A-Z]attributes are callbacks, not data: the fetch inside the callback no longer emitsprovides-data. The DELETE still reaches the dialog's lineage the right way — through the 2.3 handler chain (onClick:onConfirm --triggers--> DELETE /api/orders/selected). Data-in vs. effect-out stays distinguishable in the graph.Gate 2 (from docs/testing-strategy.md)
Passed — plus A9: scorecard 137 pass / 0 fail / 0 xfail · precision 1.000 · recall 1.000 · match accuracy 1.000.
Test plan
pnpm evalgate OK; schema regenerated (portal text source), drift gate greenDocumentation
TRACKER.md— 2.5 done, Gate 2 recorded, Status → Phase 3 (journey graph), step 3.1🤖 Generated with Claude Code