fix(parser): retain single-letter language skills - #855
Open
qtjg wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR title
fix(parser): retain single-letter language skills
PR body
Resolves #832
Summary
The skills parser previously dropped one-character programming languages because
isSkillTokenapplied an unconditional two-character minimum. This change allowlists the defensible single-letter languagesC,R, andDcase-insensitively while preserving the existing noise floor for other stray one-character glyphs.Changes
SINGLE_LETTER_SKILLSallowlist forc,r, andd.C,R, andDsurvive whileXremains rejected.skillsknownWrong entry from the LaTeX fixture and rebaked the affected corpus snapshots.Fluent in Spanishdisagreement under issue [parser] skills — a "Language: Fluent in Spanish" proficiency row is admitted as a skill token #833; the separate C-drop disagreement is now resolved by [parser] skills — single-letter language tokens (C, R, D) are dropped by isSkillToken's 2-character floor #832.UNFILED_TRUTH_CEILINGfrom 9 to 8 after filing/resolving the two repeated C-drop measurements.Verification
npm run check:baselinescompletes with the expected existing unfiled-fixture warnings; the remaining filed Google Docs skill disagreement is linked to [parser] skills — a "Language: Fluent in Spanish" proficiency row is admitted as a skill token #833.npm run verifyrun reached 358 passing test files and 5,864 passing tests, but is blocked by an unrelated existinguseLibraryChangesBroadcastChannel/jsdom failure with three unhandledMessageEventerrors. No issue [parser] skills — single-letter language tokens (C, R, D) are dropped by isSkillToken's 2-character floor #832 tests fail.