Times list filters and pagination - #44
Merged
Merged
Conversation
Adds sort/best/has_replay/invalidated filter controls to map and player
pages via a shared TimesFilterBar component. Uses the new { data, total }
envelope for accurate "Page X of Y" pagination. Moderator-gated invalidated
control with permission stripping on URL parse.
Wraps getTimes calls in try/catch/finally with a loadError ref and retry button so failed requests no longer leave the spinner running indefinitely. NaN-guards page parsing, narrows TimesFilterBar emit name to a union of known filter keys, and makes TimesListPagination.total required now that all callers provide it.
When the style filter is set to All, times across different styles are indistinguishable in the player list. Mirrors the recent-globals pattern: adds a Style column (with column widths adjusted to fit) whenever the current style filter is All, and hides it otherwise.
Member
|
Yo does this WOrk |
Member
Author
works on my machine |
Member
|
lgtm!!! - Mia |
dowoge
pushed a commit
that referenced
this pull request
Apr 18, 2026
Rebases the grid-based times list onto current main after #44 merged. Adjusts column definitions for the filter bar + pagination shape, adds TimesListHeadingColumn / TimesListItemColumn, and switches widths to position-indexed resolution so row-2-only columns (like Server in MapDetails) contribute their desktop width. Mobile header labels are now hidden for columns with rowMobile > 1 to keep the heading compact when rows stack to three rows deep.
Merged
dowoge
added a commit
that referenced
this pull request
Aug 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Migrates map, player, and recent globals to the unified /api/times
also includes a bug fix or two and showing style when All is selected as the style filter