Skip to content

fix replay viewer obsolete textures on specific maps #55

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dowoge merged 1 commit into from
May 9, 2026
Merged

fix replay viewer obsolete textures on specific maps #55

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/replay-viewer/noclip/SourceEngine/Main.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -176,7 +176,7 @@ export class SourceFileSystem {
return null;
}

private hasEntryAuthoritative(resolvedPath: string): boolean {
public hasEntryAuthoritative(resolvedPath: string): boolean {
for (let i = 0; i < this.vpk.length; i++) {
const entry = this.vpk[i].findEntry(resolvedPath);
if (entry !== null) return true;
Expand Down
14 changes: 9 additions & 5 deletions src/replay-viewer/noclip/SourceEngine/VMT.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -221,12 +221,16 @@ function stealPair(pairs: VKFPair[], name: string): VKFPair | null {
export async function parseVMT(filesystem: SourceFileSystem, path: string, depth: number = 0): Promise<VMT> {
async function parsePath(path: string): Promise<VMT> {
path = filesystem.resolvePath(path, '.vmt');
if (!filesystem.hasEntry(path)) {
// Amazingly, the material could be in materials/materials/, like is
// materials/materials/nature/2/blenddirttojunglegrass002b.vmt
// from cp_mossrock
// Amazingly, the material could be in materials/materials/, like is
// materials/materials/nature/2/blenddirttojunglegrass002b.vmt
// from cp_mossrock, or
// materials/materials/real_dev/dev_pink6.vmt
// from bhop_jaunt_2. Gate the retry on the authoritative mounts: an
// opportunistic loose mount (CSPakMount) claims every path, so a
// plain hasEntry() short-circuits the retry and the doubled-prefix
// pakfile entry never gets matched.
if (!filesystem.hasEntryAuthoritative(path) && filesystem.hasEntryAuthoritative(`materials/${path}`))
path = `materials/${path}`;
}
if (!filesystem.hasEntry(path))
path = `materials/editor/obsolete.vmt`;
// CSPakMount.hasEntry is optimistic, so 404s only surface at fetch
Expand Down