chore: stencil types - #246
Merged
Merged
Conversation
pschroen
commented
Jan 26, 2025
|
|
||
| // Same for stencil | ||
| if(this.stencil || (!target || target.stencil)) { | ||
| if (this.stencil || !target || target.stencil) { |
Contributor
Author
There was a problem hiding this comment.
@DougLilliequist is this supposed to have an and (&&) operator like the depth buffer?
if (this.stencil && (!target || target.stencil)) {
There was a problem hiding this comment.
It seems like it got merged broken since
this.stencil || !target || target.stencil
will be true if the target is null no matter what the stencil setting is...
Contributor
Author
There was a problem hiding this comment.
I don't think it's currently causing any errors, though that's why I asked.
@gordonnl we should probably fix that, even if it's not causing errors, the stencil mask is likely being set even when there is no stencil.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mirroring the stencil updates, plus house cleaning with prettier.
Related PR: #244