fix: Harden secret handling and passthrough fallbacks (backport #5799)#5825
Merged
Conversation
# What does this PR do? This PR hardens OAuth2 introspection secret handling by using `SecretStr` in config and unwrapping secret values only when sending introspection requests. It tightens messages passthrough fallbacks by catching only expected lookup errors and adding debug logs instead of silently swallowing failures. It also improves vector-store provider lookup error logging, removes a duplicate `ResponseNotFoundError` export, and drops an outdated TODO comment. ## Test Plan - `uv run pytest tests/unit/server/test_auth_oauth2_introspection.py tests/unit/providers/inline/messages/test_impl.py tests/unit/telemetry/test_vector_io_metrics.py -q --maxfail=1` - Result: `36 passed in 0.32s` Signed-off-by: Sébastien Han <seb@redhat.com> (cherry picked from commit 3921847)
mergify
Bot
requested review from
bbrowning,
cdoern,
franciscojavierarceo,
leseb,
mattf and
raghotham
as code owners
leseb
approved these changes
May 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR hardens OAuth2 introspection secret handling by using
SecretStrin config and unwrapping secret values only when sending introspection requests.It tightens messages passthrough fallbacks by catching only expected lookup errors and adding debug logs instead of silently swallowing failures.
It also improves vector-store provider lookup error logging, removes a duplicate
ResponseNotFoundErrorexport, and drops an outdated TODO comment.Test Plan
uv run pytest tests/unit/server/test_auth_oauth2_introspection.py tests/unit/providers/inline/messages/test_impl.py tests/unit/telemetry/test_vector_io_metrics.py -q --maxfail=136 passed in 0.32sThis is an automatic backport of pull request #5799 done by [Mergify](https://mergify.com).