Make care single source of truth for asset config on middleware#2000
Merged
vigneshhari merged 30 commits intodevelopfrom Apr 14, 2024
Merged
Make care single source of truth for asset config on middleware#2000vigneshhari merged 30 commits intodevelopfrom
vigneshhari merged 30 commits intodevelopfrom
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #2000 +/- ##
===========================================
+ Coverage 62.20% 62.43% +0.23%
===========================================
Files 221 222 +1
Lines 12204 12359 +155
Branches 1742 1764 +22
===========================================
+ Hits 7591 7716 +125
- Misses 4305 4320 +15
- Partials 308 323 +15 ☔ View full report in Codecov by Sentry. |
Ashesh3
approved these changes
Mar 28, 2024
khavinshankar
approved these changes
Mar 28, 2024
rithviknishad
approved these changes
Mar 28, 2024
vigneshhari
requested changes
Apr 9, 2024
| Asset.objects.filter( | ||
| current_location__facility=current_location.facility | ||
| ) | ||
| .annotate( |
Member
Author
There was a problem hiding this comment.
Converting this to or was breaking the validation
| ) | ||
| .annotate( | ||
| resolved_middleware_hostname=Coalesce( | ||
| NullIf( |
Member
There was a problem hiding this comment.
See if you can use the or statement here
Member
Author
There was a problem hiding this comment.
Converting this to or was returning assets from other hostnames as well
care/facility/migrations/0426_dailyround_is_parsed_by_ocr_and_more.py
Outdated
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Associated Issue
Merge Checklist
/docsOnly PR's with test cases included and passing lint and test pipelines will be reviewed
@coronasafe/care-backend-maintainers @coronasafe/care-backend-admins