Skip to content

Remove plugins from 10bedicu/care develop#3659

Closed
jesbinjoseph wants to merge 28 commits into
ohcnetwork:developfrom
10bedicu:no-plugin
Closed

Remove plugins from 10bedicu/care develop#3659
jesbinjoseph wants to merge 28 commits into
ohcnetwork:developfrom
10bedicu:no-plugin

Conversation

@jesbinjoseph
Copy link
Copy Markdown

@jesbinjoseph jesbinjoseph commented May 20, 2026

Proposed Changes

  • Brief of changes made.

Associated Issue

  • Link to issue here, explain how the proposed solution will solve the reported issue/ feature request.

Architecture changes

  • Remove this section if not used

Merge Checklist

  • Tests added/fixed
  • Update docs in /docs
  • Linting Complete
  • Any other necessary step

Only PR's with test cases included and passing lint and test pipelines will be reviewed

@ohcnetwork/care-backend-maintainers @ohcnetwork/care-backend-admins

Summary by CodeRabbit

  • Chores
    • Added automated Docker image building and publishing to GitHub Container Registry on code pushes and version tags.
    • Supports manual workflow dispatch for on-demand builds.

Review Change Stack

sainak and others added 28 commits February 3, 2026 12:28
Added configuration for care_radiology plug.
Add care_kutumba plug configuration
Removed existing plug configurations and initialized an empty plugs list.
@jesbinjoseph jesbinjoseph requested a review from a team as a code owner May 20, 2026 10:57
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 20, 2026

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 72eb44de-c78b-4396-825c-be10d1870ec5

📥 Commits

Reviewing files that changed from the base of the PR and between c95a6d6 and 7610afe.

📒 Files selected for processing (1)
  • .github/workflows/docker-image.yml

📝 Walkthrough

Walkthrough

This PR introduces a GitHub Actions workflow that automates Docker image builds and pushes to GHCR. The workflow triggers on manual dispatch, develop branch pushes, and version tag patterns, applying concurrency controls and dynamic metadata generation before building and publishing the image.

Changes

GHCR Image Building

Layer / File(s) Summary
Docker image build and publish workflow
.github/workflows/docker-image.yml
GitHub Actions workflow triggers on manual dispatch and version control events, generates dynamic tags using metadata-action, sets up Buildx, authenticates to ghcr.io, and builds/pushes a production Docker image for linux/amd64 with APP_VERSION and ADDITIONAL_PLUGS build arguments.

🎯 2 (Simple) | ⏱️ ~8 minutes

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@greptile-apps
Copy link
Copy Markdown

greptile-apps Bot commented May 20, 2026

Greptile Summary

This PR introduces a new .github/workflows/docker-image.yml workflow that builds and pushes a Docker image to GHCR, originating from the 10bedicu/care fork with plugin-related configuration removed.

  • The new workflow fires on the same trigger conditions (push to develop, push to v* tags, workflow_dispatch) as the already-present deploy.yml, and pushes to the same registry with identical tag names — this will cause two concurrent builds competing to overwrite the same image tags on every push.
  • Unlike deploy.yml, this workflow has no test gate before building, does not build linux/arm64, omits Docker layer caching, and lacks a Sentry release step.
  • The ADDITIONAL_PLUGS build arg references env.ADDITIONAL_PLUGS which is never populated in this workflow, so it always passes an empty string to the Dockerfile.

Confidence Score: 3/5

The workflow introduces a second CI pipeline that races the existing one to push identical Docker tags, making every build non-deterministic about which image actually lands in the registry.

Adding this file alongside the existing deploy.yml means two independent workflows push the same image tags on every develop push or version tag. Whichever run finishes last silently overwrites the other, and since deploy.yml runs tests while this one does not, a successful test-gated build can be overwritten by a test-less build.

.github/workflows/docker-image.yml needs reconciliation with the existing deploy.yml before merging.

Important Files Changed

Filename Overview
.github/workflows/docker-image.yml New Docker build-and-push workflow added; duplicates trigger events and tag patterns of the existing deploy.yml, causing two competing builds to push the same image tags on every trigger. Also references an undefined env.ADDITIONAL_PLUGS variable.

Reviews (1): Last reviewed commit: "Clear plug configurations in plug_config..." | Re-trigger Greptile

Comment on lines +3 to +11
on:
workflow_dispatch:
push:
tags:
- "v*"
branches:
- develop
paths-ignore:
- "docs/**"
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Duplicate workflow triggers conflict with deploy.yml

Both docker-image.yml and the existing deploy.yml fire on identical events (push to develop, push to v* tags, workflow_dispatch). They both push Docker images to ghcr.io/${{ github.repository }} with the same tags (latest, production-latest, etc.), so every trigger will run two competing builds racing to push the same tags — whichever finishes last wins and can silently overwrite the other's image. Additionally, deploy.yml gates its test job with if: github.repository == 'ohcnetwork/care' but this new workflow has no such repository guard, so it will also run on forks without restriction.

Comment on lines +62 to +64
build-args: |
APP_VERSION=${{ github.sha }}
ADDITIONAL_PLUGS=${{ env.ADDITIONAL_PLUGS }}
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 The ADDITIONAL_PLUGS build arg reads from env.ADDITIONAL_PLUGS, but no env block is defined anywhere in this workflow. It will always expand to an empty string. If this value needs to be configurable, it should be set in the workflow-level env block (or via a repository/environment variable).

Suggested change
build-args: |
APP_VERSION=${{ github.sha }}
ADDITIONAL_PLUGS=${{ env.ADDITIONAL_PLUGS }}
build-args: |
APP_VERSION=${{ github.sha }}
ADDITIONAL_PLUGS=

@codecov
Copy link
Copy Markdown

codecov Bot commented May 20, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 75.54%. Comparing base (4e138ff) to head (7610afe).
⚠️ Report is 10 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3659      +/-   ##
===========================================
+ Coverage    75.51%   75.54%   +0.02%     
===========================================
  Files          479      479              
  Lines        22969    22985      +16     
  Branches      2371     2375       +4     
===========================================
+ Hits         17345    17363      +18     
+ Misses        5052     5051       -1     
+ Partials       572      571       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants