Remove plugins from 10bedicu/care develop#3659
Conversation
Added configuration for care_radiology plug.
Add care_kutumba plug configuration
Removed existing plug configurations and initialized an empty plugs list.
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThis PR introduces a GitHub Actions workflow that automates Docker image builds and pushes to GHCR. The workflow triggers on manual dispatch, ChangesGHCR Image Building
🎯 2 (Simple) | ⏱️ ~8 minutes ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Greptile SummaryThis PR introduces a new
Confidence Score: 3/5The workflow introduces a second CI pipeline that races the existing one to push identical Docker tags, making every build non-deterministic about which image actually lands in the registry. Adding this file alongside the existing deploy.yml means two independent workflows push the same image tags on every develop push or version tag. Whichever run finishes last silently overwrites the other, and since deploy.yml runs tests while this one does not, a successful test-gated build can be overwritten by a test-less build. .github/workflows/docker-image.yml needs reconciliation with the existing deploy.yml before merging. Important Files Changed
Reviews (1): Last reviewed commit: "Clear plug configurations in plug_config..." | Re-trigger Greptile |
| on: | ||
| workflow_dispatch: | ||
| push: | ||
| tags: | ||
| - "v*" | ||
| branches: | ||
| - develop | ||
| paths-ignore: | ||
| - "docs/**" |
There was a problem hiding this comment.
Duplicate workflow triggers conflict with
deploy.yml
Both docker-image.yml and the existing deploy.yml fire on identical events (push to develop, push to v* tags, workflow_dispatch). They both push Docker images to ghcr.io/${{ github.repository }} with the same tags (latest, production-latest, etc.), so every trigger will run two competing builds racing to push the same tags — whichever finishes last wins and can silently overwrite the other's image. Additionally, deploy.yml gates its test job with if: github.repository == 'ohcnetwork/care' but this new workflow has no such repository guard, so it will also run on forks without restriction.
| build-args: | | ||
| APP_VERSION=${{ github.sha }} | ||
| ADDITIONAL_PLUGS=${{ env.ADDITIONAL_PLUGS }} |
There was a problem hiding this comment.
The
ADDITIONAL_PLUGS build arg reads from env.ADDITIONAL_PLUGS, but no env block is defined anywhere in this workflow. It will always expand to an empty string. If this value needs to be configurable, it should be set in the workflow-level env block (or via a repository/environment variable).
| build-args: | | |
| APP_VERSION=${{ github.sha }} | |
| ADDITIONAL_PLUGS=${{ env.ADDITIONAL_PLUGS }} | |
| build-args: | | |
| APP_VERSION=${{ github.sha }} | |
| ADDITIONAL_PLUGS= |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #3659 +/- ##
===========================================
+ Coverage 75.51% 75.54% +0.02%
===========================================
Files 479 479
Lines 22969 22985 +16
Branches 2371 2375 +4
===========================================
+ Hits 17345 17363 +18
+ Misses 5052 5051 -1
+ Partials 572 571 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Proposed Changes
Associated Issue
Architecture changes
Merge Checklist
/docsOnly PR's with test cases included and passing lint and test pipelines will be reviewed
@ohcnetwork/care-backend-maintainers @ohcnetwork/care-backend-admins
Summary by CodeRabbit