[ENG-986] Include facility identifiers in dispense order patient - #3750
Conversation
The dispense order retrieve serializer rendered the patient without a facility in context, so facility-level patient identifiers were always empty in that payload while every other facility-scoped serializer (encounter, account, diagnostic report, service request, booking) already passed one. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Team Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 2 included reviews per hour; 1 remains after this review. 📝 WalkthroughWalkthroughMedication dispense order retrieval now passes the order facility to patient serialization. ChangesMedication dispense retrieval
Estimated code review effort: 1 (Trivial) | ~3 minutes Merge Risk: ⚪ Minimal · up to This change supplies facility context when serializing dispense-order patients so facility-level identifiers appear in the view and print; no actionable merge-blocking risk remains beyond normal checks and review. Suggested reviewers: 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
Full details: Description checkExplanation The description explains the root cause, the proposed fix, the affected behavior, related frontend work, and test verification. It does not use the template headings or include the merge checklist, but it provides the critical information needed for review.
✨ Finishing Touches 💡 2📝 Generate docstrings 💡
🛠️ Fix failing CI checks 💡
🧪 Generate unit tests (beta)
Comment |
|
Need JIRA ticket before merging |
Summary
MedicationDispenseOrderRetrieveSpecserialized the patient withPatientRetrieveSpec.serialize(obj.patient)and no facility in context, sofacility_identifierswas always empty on the dispense order retrieve payload. Every other facility-scoped serializer that embeds a patient (encounter, account, diagnostic report, service request, token booking, payment reconciliation) already passesfacility=. This passesobj.facilityso the dispense order view and print can show facility-level patient identifiers.Companion frontend PR: ohcnetwork/care_fe#16765
Verification
care.emr.tests.test_dispense_order_api— 33 tests OK.🤖 Generated with Claude Code
Summary by CodeRabbit