Skip to content

DRY Permissions added for assetLocation viewset#830

Merged
vigneshhari merged 4 commits into
ohcnetwork:masterfrom
ishanExtreme:issue#818
Jun 13, 2022
Merged

DRY Permissions added for assetLocation viewset#830
vigneshhari merged 4 commits into
ohcnetwork:masterfrom
ishanExtreme:issue#818

Conversation

@ishanExtreme
Copy link
Copy Markdown

Issue Fixed

fixes #818

Updates

Read only users can now only read the location list and will not be able to perform any create/edit on it

  • Added new DRY permission class models/mixins/permissions/asset.py
  • Updated AssetLocation model to inherit from DRYPermission class
  • Updated AssetLocationViewset to use DryPermission and isAuthenticated Permission

@ishanExtreme ishanExtreme requested a review from a team as a code owner June 7, 2022 10:34
@ishanExtreme ishanExtreme requested a review from sainak June 7, 2022 10:35
Copy link
Copy Markdown
Member

@sainak sainak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Try to not change the formatting of code, It generates diff noise which makes review harder, otherwise LGTM

@vigneshhari vigneshhari merged commit f670ea9 into ohcnetwork:master Jun 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug: read-only user can edit/update location management of a facility

3 participants