Skip to content

update pre-commit hooks and dependencies#836

Merged
vigneshhari merged 2 commits into
masterfrom
sainak/fix/code-quality
Jun 9, 2022
Merged

update pre-commit hooks and dependencies#836
vigneshhari merged 2 commits into
masterfrom
sainak/fix/code-quality

Conversation

@sainak
Copy link
Copy Markdown
Member

@sainak sainak commented Jun 7, 2022

use common code style everywhere

removed

  • pycodestyle
  • pylint

closes #417

@sainak sainak requested a review from a team as a code owner June 7, 2022 13:43
@sainak
Copy link
Copy Markdown
Member Author

sainak commented Jun 7, 2022

@vigneshhari add https://pre-commit.ci/ to the repo

@vigneshhari
Copy link
Copy Markdown
Member

@sainak the app requires write access to the code, so the app won't be installed. we can keep tabs on it.

@vigneshhari vigneshhari merged commit 23c81d1 into master Jun 9, 2022
@sainak sainak deleted the sainak/fix/code-quality branch June 10, 2022 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

pre-commit fails while trying to commit the changes that we made, [un-used imports on various files]

2 participants