Add check for empty comments and notes#838
Merged
Merged
Conversation
sainak
requested changes
Jun 8, 2022
Member
|
I would create a new serializer field that has the empty check validator built-in and use that everywhere instead of re-writing the logic multiple times. Create a PR with this or create an issue to create such a field. |
vigneshhari
approved these changes
Jun 10, 2022
Member
vigneshhari
left a comment
There was a problem hiding this comment.
Changes look good, Suggestions for the next iteration provided above, Untested.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Builds on ohcnetwork/care_fe#2525
Adds a check for empty comments and notes from the backend and rejects with proper validation message when needed.
Also some minor formatting change performed automatically by
pre-commit-hooks