Fix artifactory login failures.#32
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the adp-connect.sh bootstrap script to reduce Artifactory authentication failures by clarifying the login instructions and adjusting how Artifactory credentials are collected and used during Docker registry login.
Changes:
- Updated the Artifactory login instructions shown to users (explicitly calling out SAML SSO).
- Adjusted token prompting to store the entered token before returning it from
get_artifactory_token(). - Changed Docker registry login flow to retry token entry/login when authentication fails.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
189
to
192
| instruction "${artifactory_info}" | ||
| gum input --password --width=80 --placeholder="Artifactory Token" | ||
| ARTIFACTORY_TOKEN="$(gum input --password --width=80 --placeholder="Artifactory Token")" | ||
|
|
||
| echo "${ARTIFACTORY_TOKEN}" | tr -d '[:space:]' |
Comment on lines
+1229
to
+1239
| while true; do | ||
| [[ -z "${ARTIFACTORY_TOKEN}" ]] && ARTIFACTORY_TOKEN="$(get_artifactory_token)" | ||
|
|
||
| if docker login -u "${USER_OHIOID}" --password-stdin docker."${DEFAULT_ARTIFACTORY_HOSTNAME}" <<< "${ARTIFACTORY_TOKEN}"; then | ||
| info "🎉 Successfully logged into Artifactory's Docker Registry!" | ||
| break | ||
| fi | ||
|
|
||
| warn "Artifactory login failed. Please try again." | ||
| ARTIFACTORY_TOKEN="" | ||
| done |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.