Fix release launch crash#11
Merged
Merged
Conversation
This reverts commit 5834810.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
UserDefaultsobserver from rewriting the layout preference it observesLuaconsistently as the bundle display nameRoot cause
The sidebar shell listened to
UserDefaults.didChangeNotificationand unconditionally calledsaveLayoutMode()from that listener.UserDefaults.setsynchronously emitted the same notification, recursively re-entering the observer until the main thread exhausted its stack and crashed withEXC_BAD_ACCESS.User impact
Lua v0.2.0 can crash while its first browser window appears. This patch removes the notification loop and makes future CI/release runs prove that the built app remains alive after launch.
Validation
bash -n script/smoke_launch script/verifyplutil -lint Phi.xcodeproj/project.pbxprojgit diff --check