Skip to content

Fix release launch crash#11

Merged
ojowwalker77 merged 10 commits into
mainfrom
agent/fix-v0.2.0-launch-crash
Jul 20, 2026
Merged

Fix release launch crash#11
ojowwalker77 merged 10 commits into
mainfrom
agent/fix-v0.2.0-launch-crash

Conversation

@ojowwalker77

Copy link
Copy Markdown
Owner

What changed

  • stop the sidebar shell's UserDefaults observer from rewriting the layout preference it observes
  • make performance-layout persistence idempotent and cover it with a regression test
  • add an isolated-profile runtime smoke test to both pull-request verification and the signed release archive
  • use Lua consistently as the bundle display name

Root cause

The sidebar shell listened to UserDefaults.didChangeNotification and unconditionally called saveLayoutMode() from that listener. UserDefaults.set synchronously emitted the same notification, recursively re-entering the observer until the main thread exhausted its stack and crashed with EXC_BAD_ACCESS.

User impact

Lua v0.2.0 can crash while its first browser window appears. This patch removes the notification loop and makes future CI/release runs prove that the built app remains alive after launch.

Validation

  • inspected five matching macOS crash reports; all show roughly 2,440 recursive notification frames
  • verified the installed v0.2.0 app is correctly signed and notarized, isolating the failure to runtime startup code
  • bash -n script/smoke_launch script/verify
  • plutil -lint Phi.xcodeproj/project.pbxproj
  • git diff --check
  • local Xcode compilation unavailable because this machine currently has only Command Line Tools selected; CI is the authoritative build and runtime gate

@ojowwalker77
ojowwalker77 merged commit b1cc45e into main Jul 20, 2026
2 checks passed
@ojowwalker77
ojowwalker77 deleted the agent/fix-v0.2.0-launch-crash branch July 20, 2026 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant