Conversation
emmahsax
marked this pull request as ready for review
January 19, 2025 02:40
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The tests on this repository needed a lot of work. They were only testing very outdated versions of Ruby and Rails, and the CI in GitHub Actions wasn't passing at all.
I learned most of this had to do with the specific versions of gems that were being installed for the given version of Ruby/Rails. Once I got to work ensuring the proper versions of gems were installed for each version of Ruby/Rails, then I started to get more consistent passing of the tests.
Then, I broadened the tests, and ensured they would pass for newer versions of Ruby/Rails, all the way up through Ruby 3.4 and Rails 8.0. I also pushed the tests down, so they're covering beginning with Rails 4.0 and Ruby 2.1.
At the end, I managed to get all tests passing with NO changes to the actual
app,config, orlibdirectories, and MINIMAL changes to thespecdirectory.The changes here could potentially affect when people try to run
bundle installlocally, as local development now defaults to Ruby 3.3.7 and Rails 7.2.2.1, and may decide to install different versions of gems such asconcurrent-ruby,sprockets, andsqlite3.