Skip to content

fix(cli): preserve flag values without bundle path - #14

Closed
denis-samatov wants to merge 1 commit into
okf-memory:mainfrom
denis-samatov:fix/cli-optional-path
Closed

fix(cli): preserve flag values without bundle path#14
denis-samatov wants to merge 1 commit into
okf-memory:mainfrom
denis-samatov:fix/cli-optional-path

Conversation

@denis-samatov

Copy link
Copy Markdown
Contributor

Description

Motivation & Context

Changes Made

  • [ ]

Verification & Pre-Submission Checklist

  • make test passes with 100% test success
  • make validate passes on knowledge/ (0 errors, 0 warnings, 0 orphans)
  • make validate-examples passes on all sample corpora
  • make fmt and make vet show clean code
  • Any architectural or workflow changes are documented in knowledge/

@sknr

sknr commented Sep 11, 2026

Copy link
Copy Markdown
Contributor

Hi @denis-samatov,

Thank you for this fix! Swallowing flag arguments (like --limit 3 or --type Fact) into bundleDir when no explicit path was provided was indeed a subtle and nasty CLI parsing bug. Your positional boundary separation in splitOptionalPath along with the comprehensive test coverage in cmd/okf/main_test.go solves this cleanly.

I have merged your contribution directly into our develop branch with full author attribution in commit a09e049 (along with your improvements in #15, #16, and #17).

A quick note for future contributions:
Starting today, we have updated our contribution guidelines to an Issue-First workflow on the develop branch (see CONTRIBUTING.md):

Please open an Issue first to discuss ideas or bug reports before submitting PRs.
Always base and target your PRs against develop (our default branch) rather than main (which is reserved for tagged production releases).
Please fill out the PR description template with context and verification details.
Thanks again for helping improve okf-agent-memory!

@sknr sknr closed this Sep 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants