fix(cli): preserve flag values without bundle path - #14
Conversation
|
Hi @denis-samatov, Thank you for this fix! Swallowing flag arguments (like --limit 3 or --type Fact) into bundleDir when no explicit path was provided was indeed a subtle and nasty CLI parsing bug. Your positional boundary separation in splitOptionalPath along with the comprehensive test coverage in cmd/okf/main_test.go solves this cleanly. I have merged your contribution directly into our develop branch with full author attribution in commit a09e049 (along with your improvements in #15, #16, and #17). A quick note for future contributions: Please open an Issue first to discuss ideas or bug reports before submitting PRs. |
Description
Motivation & Context
Changes Made
Verification & Pre-Submission Checklist
make testpasses with 100% test successmake validatepasses onknowledge/(0 errors, 0 warnings, 0 orphans)make validate-examplespasses on all sample corporamake fmtandmake vetshow clean codeknowledge/