Skip to content

chore: update dependencies and resolve PMD violations - #643

Merged
aniket-okta merged 3 commits into
masterfrom
OKTA-1060074
Dec 2, 2025
Merged

chore: update dependencies and resolve PMD violations#643
aniket-okta merged 3 commits into
masterfrom
OKTA-1060074

Conversation

@aniket-okta

@aniket-okta aniket-okta commented Dec 1, 2025

Copy link
Copy Markdown
Contributor

Updates multiple dependencies and GitHub Actions to their latest versions, and resolves PMD violations introduced by stricter code quality rules in okta-parent 37.

Closes #642 #641 #640 #639 #638 #637 #636 #635 #634 #633 #632 #631 #609 #610 #611 #624 #455 #510 #572

Changes

Dependencies:

  • okta-parent: 30 → 37
  • slf4j: 2.0.11 → 2.0.17
  • jackson-bom: 2.17.0 → 2.20.1
  • snakeyaml: 2.2 → 2.5
  • bcprov-jdk18on: 1.78.1 → 1.82
  • guava: 33.1.0-jre → 33.5.0-jre
  • testng: 7.10.2 → 7.11.0
  • commons-lang3: 3.18.0 → 3.19.0
  • lombok: 1.18.30 → 1.18.42
  • plexus-interpolation: 1.27 → 1.29
  • picocli: 4.7.5 → 4.7.7
  • dependency-check-maven: 9.1.0 → 12.1.9
  • maven-site-plugin: 3.12.1 → 3.21.0
  • findsecbugs-plugin: 1.12.0 → 1.14.0
  • build-helper-maven-plugin: 3.5.0 → 3.6.1

GitHub Actions:

  • actions/checkout: v4 → v6
  • graalvm/setup-graalvm: v1.4.2 → v1.4.3
  • microsoft/setup-msbuild: v1.3.1 → v2.0.0

Code Quality Fixes

Resolved 17 PMD violations introduced by stricter rules in PMD 7.7.0 (from okta-parent 37):

Common Module (3 violations):

  • Fixed UnnecessaryLocalBeforeReturn in URIs.dnsReverse()
  • Fixed UnnecessaryFullyQualifiedName in OidcProperties
  • Fixed CloseResource in TarballExtractor with proper HttpClient lifecycle management

CLI Module (14 violations):

  • Fixed 12 CloseResource violations by wrapping ConsoleOutput in try-with-resources across 10 command files
  • Fixed 2 UnusedPrivateField violations in template enums
  • Fixed ConsoleOutput.close() to not close System.out (shared JVM resource)

Bug Fixes

  • TarballExtractor: Restructured resource lifecycle to prevent premature stream closure
  • ConsoleOutput: Changed close() implementation to flush() only, preventing System.out closure
  • Native Image Build: Restored <skip>false</skip> in native-image-maven-plugin configuration

Additional Changes

  • Added CODEOWNERS file with default reviewers\

@aniket-okta
aniket-okta force-pushed the OKTA-1060074 branch 4 times, most recently from 7bb0c37 to 6d14e98 Compare December 1, 2025 16:31
@aniket-okta aniket-okta changed the title chore: update dependencies chore: update dependencies and resolve PMD violations Dec 1, 2025
@aniket-okta aniket-okta self-assigned this Dec 1, 2025

@prachi-okta prachi-okta left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants