feat: Vortex/MO2/HoloPatcher parity ports foundation#176
Merged
Conversation
added 2 commits
July 16, 2026 22:57
Identify Vortex, MO2, and HoloPatcher as the reference systems, map important capabilities and Core ports, and link the living plan to the expansion-first units.
Introduce expansion-ready Core seams (download, install backend, protocol, profiles, guides, conflicts, update-check store) wrapping existing services, land ModSyncUrl parse + draft-instruction ingest behind those ports, and persist Nexus update-check summaries without changing classic install defaults.
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
added 5 commits
July 16, 2026 23:12
Wire CLI/single-instance handoff into MainWindow (fetch instruction URL, load, activate), add OS registration builders for modsync://, and add Tools/context-menu purge plus deployment status over DeploymentService/ManagedInstallSession.
Address code-review P0/P1 on the three-project parity foundation: remap staged sources, confirm+bound instruction downloads, lock purge during live installs, confine uninstall paths, and surface managed config errors.
Resolve protocol/managed-deploy doc and launch-path overlaps after CountStages and modsync:// Phase 1 landed on master.
Keep managed session wrapping while running the fail-closed FOMOD gate from #170 on both single-component and install-all cores.
Prefer the path-sandbox and review-flag DraftInstructionService from the parity branch over the earlier guide-paste copy that landed via #173.
oldrepublicwizard
pushed a commit
that referenced
this pull request
Jul 17, 2026
Keep SettingsService-before-pickers ordering from the triage fix while retaining modsync handoff wiring from #176.
oldrepublicwizard
pushed a commit
that referenced
this pull request
Jul 17, 2026
Keep scrollable finish pages while preserving managed-deployment summary controls; take master modsync:// consume documentation.
oldrepublicwizard
pushed a commit
that referenced
this pull request
Jul 17, 2026
Align product-overview, product-vision, and KB index with consume and OS registration landed via the parity foundation merge.
This was referenced Jul 17, 2026
oldrepublicwizard
added a commit
that referenced
this pull request
Jul 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Expansion-first foundation for Vortex / MO2 / HoloPatcher parity: Core ports wrap existing services so later managed deploy, purge, and deep-link consume can plug in without a second install pipeline.
Core Ports architecture
New seams under
ModSync.Core/Ports/:IDownloadProviderRegistryover existing download handlersIInstallBackend/ classic vs managed adapters (InstallBackends); classic remains the defaultIProtocolHandler+ handlers;ModSyncUrlparse/handoff behind the portIProfileStoreover profile servicesDraftInstructionService) behind guide portsIConflictAnalyzerover the file conflict analyzerIUpdateCheckResultStorefor Nexus update-check result persistenceAdapters implement these ports; GUI/CLI stay thin. Architecture plan:
docs/plans/2026-07-16-001-three-project-parity-architecture-plan.md. Living tracker:docs/plans/vortex-mo2-feature-parity-living-plan.md.Classic default
Install path continues to use the classic backend by default. This PR does not switch production installs to managed hardlink deployment.
Deferred (not on this tip)
Follow-on work called out in the plan / living plan, not completed here:
Also includes FOMOD post-download prompt path landed via #169 on this branch history.
Test plan
dotnet test src/ModSync.Tests/ModSync.Tests.csproj --filter "FullyQualifiedName!~LongRunning"(or at leastParityPortsTests+ModSyncUrlTests)