Implement Geo Shape Query#1058
Open
heltonmarx wants to merge 2 commits intoolivere:release-branch.v6from
Open
Conversation
Based on the elasticsearch and GeoJSON specification, this PR try to solve the olivere#939 supporting the follow types : * Circle * Envelope * Linestring * MultiLineString * MultiPoint * MultiPolygon * Point * Polygon Any suggestion would be appreciated. Change-Id: If7e6f59a3833da665e31e7ec179951780d82f9c2
Change-Id: I72ce5d9647ce5c55924cb563db49de4253ae792c
avamingli
reviewed
Mar 27, 2019
| Coordinates []float64 `json:"coordinates"` | ||
| } | ||
|
|
||
| // NewCircle creates and initializes a new Circle. |
There was a problem hiding this comment.
is there a method to verify the arguments?
for example: the order of coordinates, Lon and Lat or Lat and Lon.
Author
There was a problem hiding this comment.
Good point, no, there's not, I will implement it.
Owner
|
A few initial comments on this PR:
|
Owner
|
Can we use this PR instead of #956, i.e. do you try to implement the same thing? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on the elasticsearch and GeoJSON specification, this PR tries to
solve the #939 supporting the follow types :
Any suggestion would be appreciated.