Raise themed readable-text mixes to WCAG AA contrast - #10571
Open
fresh3nough wants to merge 1 commit into
Open
Conversation
dimText, mutedText, inactive, inactiveShimmer, and lock placeholder were fixed blends toward the background. On low-headroom themes that left readable UI text below WCAG AA 4.5:1 (19/22 themes for dimText at 52%). Lower the blend amounts so every first-party colors.toml theme clears 4.5:1 while keeping muted tokens closer to the foreground than dim ones. Add a shell test that locks the template percentages and the contrast floor across all first-party themes. Fixes omacom#10533 Signed-off-by: fresh3nough <anonwurcod@proton.me>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #10533.
Readable text tokens derived as
mix(foreground, background, N%)used fixed high blends toward the background. On low-headroom first-party themes that left UI text below WCAG AA 4.5:1:pi.json.tpldimTextpi.json.tplmutedTextclaude.json.tplinactiveclaude.json.tplinactiveShimmershell.toml.tpllockplaceholderThese map to actual readable UI (
thinkingText,syntaxComment, quotes, lock placeholder), not pure decoration.Change
dimText/inactivemutedText/inactiveShimmer/ lockplaceholderHierarchy is preserved (muted stays closer to foreground than dim). Measured after the change: 0/22 themes below 4.5:1, minimum dim contrast 4.55:1 (
rose-pine).Evidence
Reproduced from shipped
themes/*/colors.tomlonly (no hardware):Test plan
bash test/shell.d/theme-dimtext-contrast-test.shomarchy theme seta low-headroom theme (e.g. rose-pine) and spot-check lock placeholder / Pi thinking text