fix: link the current icon into the Windows executable - #175
Merged
Conversation
omartelo
commented
Aug 6, 2026
omartelo
commented
Owner
The .syso the Windows binary links still carried the purple meteor mark retired in #128, which updated build/windows/lich.ico and the PNGs but not the resource generated from them. Nothing in the repo said how that resource is produced, so there was nothing to remind the reskin. The executable's icon is what Windows draws in the two places the Chromium window never covers: the Start Menu shortcut, which the installer points at lich.exe with no IconFilename of its own, and the taskbar button of the file picker — ncruces/zenity runs an in-process IFileOpenDialog there, so the dialog is a window of lich's own. Regenerate the resource from lich.ico and add `task icons:windows`, so the next icon change has a recipe to run instead of a binary to remember.
omartelo
added a commit
that referenced
this pull request
Aug 7, 2026
Move the [Unreleased] entries under a 0.27.0 heading and refresh the compare links. Also split an entry the previous release cycle merged into one. The Chromium prompts fix (#177) replaced the header line of the Windows icon fix (#175) instead of adding its own above it, leaving the icon entry's body attached to a fix it has nothing to do with. Both are separate Fixed entries again.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.