Do not override default Travis commands #4
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
From https://docs.travis-ci.com/user/languages/java/#Projects-Using-Maven, the default Travis environment firsts calls `mvn install` skipping tests and Javadoc then `mvn test`. Overriding `mvn install` is unnecessary and causes the tests to be executed twice. This commit should increase the build time.
Member
Author
|
See https://travis-ci.org/ome/ome-common-java/pull_requests |
Contributor
|
The change is fine and everything is green. Please merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From https://docs.travis-ci.com/user/languages/java/#Projects-Using-Maven, the default Travis environment firsts calls
mvn installskipping tests and Javadoc thenmvn test.Overriding
mvn installis unnecessary and causes the tests to be executed twice. This commit should increase the build time.