Merged
Conversation
Member
|
Conflicting PR. Removed from build OMERO-plugins-push#101. See the console output for more details.
|
dominikl
reviewed
Nov 29, 2019
Member
|
Looks good. Just one comment (see above), and when I ran it, got a warning: Edit: The warning doesn't have anything to do with the PR though, seems to be a python3 thing. |
Member
|
Tested again, works. Good to merge 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While working on a feature allowing to process multiple images with multiple rendering settings, I found it useful to refactor the logic of the
render setcommand dealing with loading and parsing rendering settings from a source (object or file on disk).The changes included in this PR should not changing behavior, include some cleanup (
print->debug) as well as unit tests starting to cover some of the individual functionalities