Set rendering settings for inactive channels#43
Merged
sbesson merged 2 commits intoome:masterfrom Jul 17, 2020
Merged
Conversation
With the current version of the plugin, rendering settings are lost if channels are set to inactive
Member
|
Looks good 👍 I think too that the change of behaviour is fine, as the current behaviour is definitely not what one would expect. |
Member
Author
|
Merging and tagging as |
|
This pull request has been mentioned on Image.sc Forum. There might be relevant details there: https://forum.image.sc/t/omero-cli-render-set-cant-adjust-disabled-channels/56273/2 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR attempts to fix the behavior of the current render plugin when a YML/JSON file contains rendering settings (color, start/end window) for both active and inactive channels. In the current scenario, the rendering settings for the inactive channels are silently ignored. fc9cee4 contains a failing test capturing this behavior.
This issue was the primary motivation behind the
omero.gatewayAPI introduced in ome/openmicroscopy#5955. With this change, rendering settings should be applied independently of the active state of the channel if specified via the configuration file.Opening this as a behavior change of the plugin as I consider the current implementation as faulty and inconsistent with the fact channel names are set unconditionally. If backward compatibility and/or support for the previous behavior is valuable, this could be introduced as a
--{ignore,set}-inactiveoption for thesetcommand.