Merged
Conversation
Member
|
Tested the culprit renderer.yml, no problem noticed this time:
and
|
Member
Author
|
i.e. LGTM and released? |
Member
|
Sorry |
Member
Author
|
Now released as https://pypi.org/project/omero-cli-render/0.6.1/ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reported by @jburel. In the absence of an explicit
versionkey in the rendering file, the detection logic in_getversion()is currently checking the presence ofstart/endvsmin/maxkeys (as the semantics of these has changed since version 1 and 2) and unconditionally returning0(undefined version) in absence of any of these keys. This means a simple rendering file as the following is currently detected as invalid:ab081ac fixes this issue by returning the version of the latest specification version (
2)in this case. 28a10df also increases the type and the range of supported versions when theversionargument is present. Several unit tests have been added that should test various YML files and the plugin expectation when loading these.Travis unit and integration tests should keep passing. Additionally, a simple test should be run with a minimal YML file like the one mentioned above.
omero render setshould fail without this PR and pass with this PR included.Proposed relase: 0.6.1