Skip to content

Conversation

@will-moore
Copy link
Member

This improves handling of Big images in Batch Image Export script.

Previously, the first check was the 'omero.client.download_as.max_size' setting (regardless of which format you were exporting). And if smaller than this limit then OME-TIFF export would go ahead, even if image was a 'Big' (tiled) image that is not supported by OME-TIFF exporter service.

Now, we first check the export format.
If OME-TIFF, then we check if it's a 'Big' (tiled) image.
Otherwise we check if it's under the 'omero.client.download_as.max_size' limit (12k * 12k by default).

To test:

  • Try to export a single image (over 12k * 12k) as JPG / PNG. Should get sensible message in scripts activities and log.
  • Try to export a single 'Big' image at OME-TIFF (can use same image as above). Should get a different message in scripts activities and log.
  • Try to export multiple images as OME-TIFF or PNG/JPG. If some are too big these will give message in log. If none are export (all too big) should see reasonable message. Otherwise will get zip.

screen shot 2016-05-17 at 16 47 40

@gusferguson
Copy link

@will-moore

Tested with cowfish user-3 read-only-1

Behaves as expected.
Good to merge.

@jburel
Copy link
Member

jburel commented Oct 4, 2016

What happens if I select a large number of them?
Did you try that @gusferguson ?

@will-moore
Copy link
Member Author

This PR isn't trying to improve handling of large number of images (which is why I didn't ask for that in the tests). This is trying to fix the OME-TIFF export going ahead with a 'Big' image & getting an error (not supported).

@gusferguson
Copy link

I tried with about 5 I think.

@jburel
Copy link
Member

jburel commented Oct 4, 2016

My point about large number is that big images+few images might become an issue.
Opening to "big image" might lead to other issues that need to be looked at.

@will-moore
Copy link
Member Author

The point of this PR was simply to fix the logic of handling 'Big' images that are less than 12k * 12k. It doesn't attempt to address any issues with downloads of large amounts of data.
If you try to zip up a large amount of data, it will work up to some limit which we haven't tried to determine and which will be different on different hardwear etc. While it may be interesting to know that, it doesn't really affect the logic in this PR.
If it's something we want to look into, lets make a trello card somewhere. However, in general batch_image_export script isn't affected by large data as much as Download from web (timeout issues etc).

@jburel
Copy link
Member

jburel commented Oct 5, 2016

I understand, I am just raising a point since we have not been too careful in the past with some scripts e.g. projection
If you can add a card, that will be great

@will-moore
Copy link
Member Author

@jburel
Copy link
Member

jburel commented Oct 5, 2016

Thanks

@jburel jburel merged commit 67e10b3 into ome:develop Oct 5, 2016
@jburel jburel added this to the 5.3.0 milestone Mar 29, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants