Skip to content

Conversation

@will-moore
Copy link
Member

See https://trello.com/c/rE4VXlX1/33-figure-scripts-rotate-labels-bug
Fixes bug in rotation of labels for figure scripts, previously fixed in OMERO.figure https://github.com/ome/omero-figure/pull/140/files and reported at https://www.openmicroscopy.org/community/viewtopic.php?f=4&t=8303

To test, create a Split_View_Figure with the script, and check the vertical labels.
Before and after screenshot:

screen shot 2017-06-22 at 11 59 42

@will-moore will-moore changed the title Fix label rotate() in Split_View_Figure.py and Movie_Figure.py label_rotate_fix Jun 22, 2017
@jburel
Copy link
Member

jburel commented Jun 23, 2017

I have tried on eel and nightshade, the label is correctly displayed with and without the PR
eel has Pillow==2.7.0 installed.
So the change is not "break" older version
I will need to test it locally where I have a newer version of Pillow

@jburel
Copy link
Member

jburel commented Jun 23, 2017

Tested with Pillow==3.4.2
Label is not correctly rotated without the changes
Including this change for the coming 5.3.3 release

@jburel jburel merged commit 092e9ae into ome:develop Jun 23, 2017
@jburel jburel added this to the 5.3.3 milestone Jun 27, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants