Partial rebase of 4744 Use client-side protocol/host in URL#4792
Merged
joshmoore merged 4 commits intoome:developfrom Aug 26, 2016
Merged
Partial rebase of 4744 Use client-side protocol/host in URL#4792joshmoore merged 4 commits intoome:developfrom
joshmoore merged 4 commits intoome:developfrom
Conversation
This removes the need for another config property
This was referenced Aug 19, 2016
Member
Author
|
Partially |
Member
|
Sorry - missed this yesterday. Looking now... |
Member
|
Not sure that I understand the "problems with server-side caching" but this certainly seems to be working fine. and all the link functionality works fine as described. Good to merge. |
Member
@will-moore, the problem we were seeing is that the URL that someone used to access a resource (http://idr-demo.openmicroscopy.org/webclient/?show=plate-2551 vs http://idr-demo2.openmicroscopy.org/webclient/?show=plate-2551, aliases for each other) was being stored in the metadata cache for the right-hand panel. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Partial rebase of #4744
What this PR does
The web metadata panel
Link to this <object>contains a server side URL created from the HTTPHostheader. This causes problems with server-side caching.locationobject, so that the/pathwill be cached but theprotocol://hostwill be handled by the client browserTesting this PR
Link to this <object>in the web RH metadata panel. The URL should use whatever the browser has in the location bar, and in additional examination of the returned html such ashttp://host/webclient/metadata_details/image/ID/should showvar lnk = location.protocol + "//" + location.host + "/webclient/";instead of a URL.The following additions from #4744 related to twitter/opengraph support (#4613) have not been rebased:
omero.web.ui.omero.web.ui.external_link_baseurl(this must include the protocol).Related reading
Link to cards, tickets, other PRs:
Note
The only other place I'm aware of that let's you copy a link is in the full image viewer where it is already generated by client-side javascript: https://github.com/manics/openmicroscopy/blob/metadata52-linkto/components/tools/OmeroWeb/omeroweb/webgateway/templates/webgateway/viewport/omero_image.html#L665
This is unchanged, but maybe it should be unified?