Web api app2#4945
Closed
will-moore wants to merge 26 commits into
Closed
Conversation
Using a single OjbectView to handle single Project or Dataset but creating a new DatasetsView to handle listing of Datasets
We want to provide a more user-friendly way to add extra parameters to the query that also allows other filters etc that are not supported in ParametersI
'No Permissions' errors seen in https://trac.openmicroscopy.org/ome/ticket/11362 are caused by trying to load groups that are not your default group when using ctx omero.group:-1
This means the query won't fail if the query string has extra select statements. E.g. if child_count=True in _getQueryString()
Previously if this test failed once and left undeleted Objects, subsequent tests would find these and fail again, leaving even more undeleted objects. Now we cleanup first before checking for orphanedCount. So, even if it fails once, it will cleanup next time then start passing again.
will-moore
added a commit
to will-moore/openmicroscopy
that referenced
this pull request
Nov 17, 2016
will-moore
added a commit
to will-moore/openmicroscopy
that referenced
this pull request
Nov 17, 2016
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does
Adds support for Datasets to the web api.
This also moves more logic for building queries to the BlitzGateway, to reduce duplication within api_query.py.
This means that the _getQueryString() for each BlitzGateway Wrapper object now returns a base query string, params and clauses. These are then augmented in conn.buildQuery(), which is used both by conn.getObjects() and by the web /api_query.py.
cc @chris-allan
TODO: maybe add more Dataset tests, similar to test_api_project.py, but less extensive.