Skip to content

Use problem functions from openapi repo - #356

Merged
gab-arrobo merged 1 commit into
omec-project:mainfrom
gab-arrobo:problem-functions
Jun 23, 2026
Merged

Use problem functions from openapi repo#356
gab-arrobo merged 1 commit into
omec-project:mainfrom
gab-arrobo:problem-functions

Conversation

@gab-arrobo

Copy link
Copy Markdown
Contributor

No description provided.

Signed-off-by: Arrobo, Gabriel <gabriel.arrobo@intel.com>

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR standardizes ProblemDetails creation across PCF services by replacing manual models.NewProblemDetails() construction with shared helper functions from github.com/omec-project/openapi/v2/utils, improving consistency with the OpenAPI repo’s problem definitions.

Changes:

  • Switched multiple routers’ “not implemented” default handler responses to utils.ProblemDetailsNotImplemented(...).
  • Updated producers to use utils helpers for common error conditions (context not found, mandatory IE missing, and specific causes via ProblemDetailsWithCause).
  • Adjusted unit test expectations to build ProblemDetails via the same utils helpers as production code.

Reviewed changes

Copilot reviewed 9 out of 9 changed files in this pull request and generated no comments.

Show a summary per file
File Description
uepolicy/routers.go Use utils.ProblemDetailsNotImplemented for default 501 ProblemDetails responses.
smpolicy/routers.go Use utils.ProblemDetailsNotImplemented for default 501 ProblemDetails responses.
policyauthorization/routers.go Use utils.ProblemDetailsNotImplemented for default 501 ProblemDetails responses.
bdtpolicy/routers.go Use utils.ProblemDetailsNotImplemented for default 501 ProblemDetails responses.
ampolicy/routers.go Use utils.ProblemDetailsNotImplemented for default 501 ProblemDetails responses.
producer/oam.go Replace manual 404 ProblemDetails creation with utils.ProblemDetailsContextNotFound.
producer/callback.go Replace manual 400 ProblemDetails creation with utils.ProblemDetailsMandatoryIeMissing.
producer/bdtpolicy.go Replace local/util ProblemDetails creation with utils helpers incl. ProblemDetailsWithCause.
pcftests/pcf_test.go Update tests to construct expected ProblemDetails via utils helpers.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@gab-arrobo
gab-arrobo merged commit 23d8a3a into omec-project:main Jun 23, 2026
12 checks passed
@gab-arrobo
gab-arrobo deleted the problem-functions branch June 23, 2026 00:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants