Use problem functions from openapi repo - #356
Merged
Merged
Conversation
Signed-off-by: Arrobo, Gabriel <gabriel.arrobo@intel.com>
There was a problem hiding this comment.
Pull request overview
This PR standardizes ProblemDetails creation across PCF services by replacing manual models.NewProblemDetails() construction with shared helper functions from github.com/omec-project/openapi/v2/utils, improving consistency with the OpenAPI repo’s problem definitions.
Changes:
- Switched multiple routers’ “not implemented” default handler responses to
utils.ProblemDetailsNotImplemented(...). - Updated producers to use
utilshelpers for common error conditions (context not found, mandatory IE missing, and specific causes viaProblemDetailsWithCause). - Adjusted unit test expectations to build ProblemDetails via the same
utilshelpers as production code.
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
uepolicy/routers.go |
Use utils.ProblemDetailsNotImplemented for default 501 ProblemDetails responses. |
smpolicy/routers.go |
Use utils.ProblemDetailsNotImplemented for default 501 ProblemDetails responses. |
policyauthorization/routers.go |
Use utils.ProblemDetailsNotImplemented for default 501 ProblemDetails responses. |
bdtpolicy/routers.go |
Use utils.ProblemDetailsNotImplemented for default 501 ProblemDetails responses. |
ampolicy/routers.go |
Use utils.ProblemDetailsNotImplemented for default 501 ProblemDetails responses. |
producer/oam.go |
Replace manual 404 ProblemDetails creation with utils.ProblemDetailsContextNotFound. |
producer/callback.go |
Replace manual 400 ProblemDetails creation with utils.ProblemDetailsMandatoryIeMissing. |
producer/bdtpolicy.go |
Replace local/util ProblemDetails creation with utils helpers incl. ProblemDetailsWithCause. |
pcftests/pcf_test.go |
Update tests to construct expected ProblemDetails via utils helpers. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
cmaciocco
approved these changes
Jun 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.