Skip to content

Conversation

@pboling
Copy link
Member

@pboling pboling commented Nov 4, 2025

  • based on dependency "net-ldap", "~> 0.16"
  • switches from rubocop-lts v0 => v4
  • switches from rubocop-ruby-1_8 => rubocop-ruby2_0

@pboling pboling self-assigned this Nov 4, 2025
Copilot AI review requested due to automatic review settings November 4, 2025 21:21
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR modernizes Ruby hash syntax throughout the codebase by converting the older hash rocket syntax (:key => value) to the modern Ruby 1.9+ syntax (key: value). Additionally, it updates documentation and comments to accurately reflect that nkf was changed to a bundled gem (not removed) in Ruby 3.4, updates the minimum required Ruby version from 0 to 2.0, and upgrades rubocop-lts tooling.

Key changes:

  • Converted hash syntax from :key => value to key: value across production code, specs, gemfiles, and configuration files
  • Updated minimum Ruby version requirement from >= 0 to >= 2.0 in gemspec
  • Corrected technical inaccuracy: nkf was "changed to a bundled gem" (not "removed") in Ruby 3.4
  • Updated rubocop-lts dependencies and version constraints

Reviewed Changes

Copilot reviewed 36 out of 38 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
spec/spec_helper.rb Updated hash syntax in RSpec configuration
spec/omniauth/strategies/ldap_spec.rb Modernized hash syntax in LDAP strategy tests
spec/omniauth-ldap/adaptor_spec.rb Updated hash syntax in adaptor tests
omniauth-ldap.gemspec Changed minimum Ruby version to 2.0 and corrected nkf documentation
lib/omniauth/strategies/ldap.rb Modernized hash syntax in LDAP strategy implementation
lib/omniauth-ldap/adaptor.rb Updated hash syntax in adaptor and corrected nkf comment
gemfiles/*.gemfile Converted hash syntax in all gemfile configurations
gemfiles/modular/style.gemfile Updated rubocop dependencies and hash syntax
README.md Updated documentation with modern hash syntax, corrected Ruby version info, and added Ruby 3.4 section
Guardfile Updated hash syntax in Guard configuration
Gemfile.lock Updated rubocop-lts dependencies from v0.1 to v4.0
.yard_gfm_support.rb Modernized hash syntax in YARD configuration
.rubocop_gradual.lock Updated gradual linting lock file checksums

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

- based on dependency "net-ldap", "~> 0.16"
@pboling pboling force-pushed the feat/integration-tests branch from 86a18bc to 648f205 Compare November 4, 2025 21:24
@pboling pboling merged commit 9d28d65 into main Nov 4, 2025
26 of 27 checks passed
@pboling pboling deleted the feat/integration-tests branch November 4, 2025 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants